public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH rdma-core] qedr: Fix a wrong field in struct rdma_rq_sge
@ 2017-01-17 19:44 Tatyana Nikolova
       [not found] ` <1484682252-32964-1-git-send-email-tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Tatyana Nikolova @ 2017-01-17 19:44 UTC (permalink / raw)
  To: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
	dledford-H+wXaHxf7aLQT0dZR+AlfA, leonro-VPRAkNaXOzVWk0Htik3J/w
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Fixes: 13b2b3cf148c ("libqedr: fix queue wrapping logic")

After enabling FP_DP_VERBOSE macro, for example:
#define FP_DP_VERBOSE(...)     DP_VERBOSE(__VA_ARGS__)

libqedr compilation fails with the error below:

In file included from ../providers/qedr/qelr_verbs.c:48:0:
../providers/qedr/qelr_verbs.c: In function ‘qelr_post_recv’:
../providers/qedr/qelr_verbs.c:1447:14: error: ‘struct rdma_rq_sge’ has no member named ‘first_addr’
           rqe->first_addr.hi, rqe->first_addr.lo);

Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 providers/qedr/qelr_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/providers/qedr/qelr_verbs.c b/providers/qedr/qelr_verbs.c
index 793b1f4..93a0e35 100644
--- a/providers/qedr/qelr_verbs.c
+++ b/providers/qedr/qelr_verbs.c
@@ -1444,7 +1444,7 @@ int qelr_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr,
 			FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ,
 				      "[%d]: len %d key %x addr %x:%x\n", i,
 				      rqe->length, rqe->flags,
-				      rqe->first_addr.hi, rqe->first_addr.lo);
+				      rqe->addr.hi, rqe->addr.lo);
 		}
 		/* Special case of no sges. FW requires between 1-4 sges...
 		 * in this case we need to post 1 sge with length zero. this is
-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH rdma-core] qedr: Fix a wrong field in struct rdma_rq_sge
       [not found] ` <1484682252-32964-1-git-send-email-tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2017-01-18 16:19   ` Leon Romanovsky
  0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2017-01-18 16:19 UTC (permalink / raw)
  To: Tatyana Nikolova
  Cc: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
	dledford-H+wXaHxf7aLQT0dZR+AlfA,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Tue, Jan 17, 2017 at 01:44:12PM -0600, Tatyana Nikolova wrote:
> Fixes: 13b2b3cf148c ("libqedr: fix queue wrapping logic")
>
> After enabling FP_DP_VERBOSE macro, for example:
> #define FP_DP_VERBOSE(...)     DP_VERBOSE(__VA_ARGS__)
>
> libqedr compilation fails with the error below:
>
> In file included from ../providers/qedr/qelr_verbs.c:48:0:
> ../providers/qedr/qelr_verbs.c: In function ‘qelr_post_recv’:
> ../providers/qedr/qelr_verbs.c:1447:14: error: ‘struct rdma_rq_sge’ has no member named ‘first_addr’
>            rqe->first_addr.hi, rqe->first_addr.lo);
>
> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>  providers/qedr/qelr_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This fix isn't relevant anymore, Ram deleted these macros.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-18 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 19:44 [PATCH rdma-core] qedr: Fix a wrong field in struct rdma_rq_sge Tatyana Nikolova
     [not found] ` <1484682252-32964-1-git-send-email-tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-18 16:19   ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox