From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH RFC rdma-core 1/3] util: Add common code for provider debug Date: Sun, 22 Jan 2017 10:11:18 +0200 Message-ID: <20170122081118.GF28570@mtr-leonro.local> References: <1484682413-56580-1-git-send-email-tatyana.e.nikolova@intel.com> <20170118053130.GS32481@mtr-leonro.local> <20170118164444.GA14198@obsidianresearch.com> <20170118183104.GH32481@mtr-leonro.local> <20170118184411.GA5020@obsidianresearch.com> <20170119080924.GM32481@mtr-leonro.local> <20170119175838.GC8109@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hUH5gZbnpyIv7Mn4" Return-path: Content-Disposition: inline In-Reply-To: <20170119175838.GC8109-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Tatyana Nikolova , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-rdma@vger.kernel.org --hUH5gZbnpyIv7Mn4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 19, 2017 at 10:58:38AM -0700, Jason Gunthorpe wrote: > On Thu, Jan 19, 2017 at 10:09:24AM +0200, Leon Romanovsky wrote: > > On Wed, Jan 18, 2017 at 11:44:11AM -0700, Jason Gunthorpe wrote: > > > On Wed, Jan 18, 2017 at 08:31:04PM +0200, Leon Romanovsky wrote: > > > > On Wed, Jan 18, 2017 at 09:44:44AM -0700, Jason Gunthorpe wrote: > > > > > On Wed, Jan 18, 2017 at 07:31:30AM +0200, Leon Romanovsky wrote: > > > > > > > +#define PRINT_ERR(fmt, ...) \ > > > > > > > +do { \ > > > > > > > + fprintf(stderr, "[%s:%d]" fmt, __func__, __LINE__, ##__VA_ARGS__); \ > > > > > > > +} while (0) > > > > > > > + > > > > > > > +#define PRINT_DBG(dbg_mask, dbg_level, fmt, ...) \ > > > > > > > +do { \ > > > > > > > + if ((rdma_dbg_mask & dbg_mask) && (rdma_dbg_level >= dbg_level)) \ > > > > > > > + fprintf(stderr, "[%s:%d]" fmt, __func__, __LINE__, ##__VA_ARGS__); \ > > > > > > > +} while (0) > > > > > > > + > > > > > > > +#define LOG_DBG(dbg_fp, dbg_mask, dbg_level, fmt, ...) \ > > > > > > > +do { \ > > > > > > > + if ((rdma_dbg_mask & dbg_mask) && (rdma_dbg_level >= dbg_level)) \ > > > > > > > + fprintf(dbg_fp, "[%s:%d]" fmt, __func__, __LINE__, ##__VA_ARGS__); \ > > > > > > > +} while (0) > > > > > > > + > > > > > > > +#define LOG_DBG_FLUSH(dbg_fp, dbg_mask, dbg_level, fmt, ...) \ > > > > > > > +do { \ > > > > > > > + LOG_DBG(dbg_fp, dbg_mask, dbg_level, fmt, ##__VA_ARGS__); \ > > > > > > > + if (dbg_fp != stderr) \ > > > > > > > + fflush(dbg_fp); \ > > > > > > > +} while (0) > > > > > > > > > > > > IMHO, these macros should be inline functions, and better to avoid global variables. > > > > > > > > > > It is more expensive at the call site to inline something that calls > > > > > via va_args than via ..., so these should remain as macros. > > > > > > > > These macros/functions need to be compiled in for DEBUG mode only, in > > > > such case you can pay extra CPU cycles. > > > > > > One of the reasonable ways to use this is to always compile in *error > > > case* debug prints, as these are intrinsically on the slow error path > > > already - however for that use we certainly want to minimize icache > > > consumption at the call site. > > > > There are debug prints in data path too. > > https://patchwork.kernel.org/patch/9521817/ > > See mlx5_get_next_cqe and mlx5_cq_read_wc_opcode functions. > > I was suggesting two debug entry points, one that is compiled out and the > other that is not. Exactly, I just didn't understand it from your previous responses. Thanks > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --hUH5gZbnpyIv7Mn4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAliEaSYACgkQ5GN7iDZy WKe3Tg/8Dsx61GMS0iWVuM+wpZDJ9K3JCk/oAi6k8Be4iDeJwE5eLk2v0ic2XtBl C57LcuvzLgEQwyiZityGEoXActYpsgGJMFONbO2ql0GiOs/xdmw3N2FG4HwqLhkD uTTHM9H/Si9vqWyE8YI7xoHoNjf3p+LH4tnKHgvECJVtIVIUBCq/igK5zix7UEyK dVVTqF98JYfvZja9H8hzQuf/5EURR1sJVAQtExTcdn+2y95ehW1retgYjamf4oq9 pgV/rjCFNEDwh2P1hKfZ6d5qvCHNTdv6/uM9EBCRbyR5gQUWoqMI7Zfr5xtgb4ns zvGXvUtpKpP9/hAJL5wnhNRvS4fd1s+TMfbWOSLFlBlkx/2I5iCdeqbl6ydA03v9 KkHP0jqxLzN6zXXhDlYo6r7tLKF2BGroeiRwJpB/2sElWVcEoV+AEoObrNTXscpo e6Ui0ZmbV90plc/goYk1LOg35ZZxi7yJxMveqNAyMuZ8/WbG5k5cyNf2QqcYaxIs F2pdhaabcUpWqlINhuI7VUeBTbjFKwJDME3NCU3Ck2+vs6MKOp16h6XrSLBhSCW8 GzOmj0jeS/soDOzWy98jzHZukMp/jSUgJCjiHKlmiuYkp48D/5nBYeJ1rqGN7Hz1 YFrsShZq38JQKquA15AXpvoAOKnLyiR9+f8cJ/EVebtOLo3z/L8= =eBV/ -----END PGP SIGNATURE----- --hUH5gZbnpyIv7Mn4-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html