From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH rdma-core 1/7] mlx5: Add mlx5 direct verbs files
Date: Thu, 26 Jan 2017 10:27:42 -0700 [thread overview]
Message-ID: <20170126172742.GC16562@obsidianresearch.com> (raw)
In-Reply-To: <1485446182-5109-2-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jan 26, 2017 at 05:56:16PM +0200, Yishai Hadas wrote:
> +add_subdirectory(include)
No need for a subdirectory. I've been flattening things for a while
> +/* Always inline the function */
> +#ifdef __GNUC__
> +#define MLX5DV_ALWAYS_INLINE inline __attribute__((always_inline))
> +#else
> +#define MLX5DV_ALWAYS_INLINE inline
> +#endif
I doubt this is necessary... static inline is fine these days.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-26 17:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:56 [PATCH rdma-core 0/7] Add mlx5 direct verbs Yishai Hadas
[not found] ` <1485446182-5109-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-26 15:56 ` [PATCH rdma-core 1/7] mlx5: Add mlx5 direct verbs files Yishai Hadas
[not found] ` <1485446182-5109-2-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-26 17:27 ` Jason Gunthorpe [this message]
2017-01-26 15:56 ` [PATCH rdma-core 2/7] mlx5: Add CQE fields Yishai Hadas
2017-01-26 15:56 ` [PATCH rdma-core 3/7] mlx5: Add WQE segments implementation Yishai Hadas
2017-01-26 15:56 ` [PATCH rdma-core 4/7] mlx5: Use macro for CQE version 1 Yishai Hadas
2017-01-26 15:56 ` [PATCH rdma-core 5/7] mlx5: Convert to use predefined get CQE opcodes Yishai Hadas
2017-01-26 15:56 ` [PATCH rdma-core 6/7] mlx5: Unify exported and internal CQE format Yishai Hadas
2017-01-26 15:56 ` [PATCH rdma-core 7/7] mlx5: Export mlx5 direct verbs interface Yishai Hadas
[not found] ` <1485446182-5109-8-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-26 17:30 ` Jason Gunthorpe
[not found] ` <20170126173005.GD16562-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-03 16:04 ` Christoph Hellwig
[not found] ` <20170203160419.GA28953-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-03 16:48 ` Jason Gunthorpe
2017-01-26 17:25 ` [PATCH rdma-core 0/7] Add mlx5 direct verbs Jason Gunthorpe
[not found] ` <20170126172511.GB16562-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-26 21:54 ` Yishai Hadas
[not found] ` <ac21fe37-d617-e5a8-cd67-e8fdfbd69d55-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-01-26 22:02 ` Jason Gunthorpe
2017-02-01 15:56 ` Christoph Lameter
[not found] ` <alpine.DEB.2.20.1702010956080.12203-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2017-02-01 16:17 ` Leon Romanovsky
2017-02-02 8:52 ` Sagi Grimberg
[not found] ` <782c31cb-e247-1094-955f-2766f9c66cbd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-02-02 13:15 ` Yishai Hadas
2017-02-06 10:56 ` Amrani, Ram
[not found] ` <SN1PR07MB22070381E7566FA819E5F8F8F8400-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-02-06 11:46 ` Leon Romanovsky
[not found] ` <20170206114609.GK6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-06 16:39 ` Jason Gunthorpe
[not found] ` <20170206163937.GB14714-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-08 18:45 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126172742.GC16562@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox