Re: rdma-core 12 breaks libibverbs ABI

Jason Gunthorpe
2017-01-31T16:38:02Z

On Tue, Jan 31, 2017 at 01:23:03PM +0100, Benjamin Drung wrote:
> Am Donnerstag, den 26.01.2017, 09:35 -0800 schrieb Christoph Hellwig:
> > On Thu, Jan 26, 2017 at 10:13:25AM -0700, Jason Gunthorpe wrote:
> > > I missed asking for this when the ibv_cmd_create_ah@IBVERBS_1.4
> > > patch
> > > was merged, but before we release 13 we need to drop all the
> > > ibv_cmd_*
> > > entry points from the public headers so that nothing outside rdma-
> > > core
> > > can link to these symbols.
> >
> > A good thing would be to move all these symbols into a
> > @IBVERBS_PRIVATE
> > namespace, similar to what glibc does for it's internal library only
> > exports.
>
> I am fine with moving the private symbols into a IBVERBS_PRIVATE_XX
> namespace as long as all consumers of the private symbols are build
> from the rdma-core source package. I need to check if there is a
> package in Debian that uses the private symbols.

> So either go forward (extra namespace for private symbols) or revert
> the ABI breakage (for the time being). The discussion on this list seem
> to prefer the first option.

Yes.

We must implement one of the two options before releasing '13'

I have sent patches on github to do the first..

Jason