public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Benjamin Drung
	<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: rdma-core 12 breaks libibverbs ABI
Date: Thu, 26 Jan 2017 11:09:26 -0700	[thread overview]
Message-ID: <20170126180926.GB20330@obsidianresearch.com> (raw)
In-Reply-To: <20170126173548.GA15006-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Thu, Jan 26, 2017 at 09:35:48AM -0800, Christoph Hellwig wrote:
> On Thu, Jan 26, 2017 at 10:13:25AM -0700, Jason Gunthorpe wrote:
> > I missed asking for this when the ibv_cmd_create_ah@IBVERBS_1.4 patch
> > was merged, but before we release 13 we need to drop all the ibv_cmd_*
> > entry points from the public headers so that nothing outside rdma-core
> > can link to these symbols.
> 
> A good thing would be to move all these symbols into a @IBVERBS_PRIVATE
> namespace, similar to what glibc does for it's internal library only
> exports.

Makes sense for clarity.

I guess we should remove the public headers and change the symbol
version all at once in '13'? This would instantly make all out of tree
providers totally unworkable.

Or go back to providing strong compat to the providers as Ben
suggested..  In this case someone will have to vote for this with a
patch to put the missing symbol back...

I know mlx voted for the first path - Ira?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-01-26 18:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 15:55 rdma-core 12 breaks libibverbs ABI Benjamin Drung
     [not found] ` <1485446147.4194.4.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-01-26 17:13   ` Jason Gunthorpe
     [not found]     ` <20170126171325.GA16562-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-26 17:35       ` Christoph Hellwig
     [not found]         ` <20170126173548.GA15006-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-01-26 18:09           ` Jason Gunthorpe [this message]
     [not found]             ` <20170126180926.GB20330-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-26 18:11               ` Christoph Hellwig
     [not found]                 ` <20170126181113.GA8679-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-01-26 18:27                   ` Jason Gunthorpe
     [not found]                     ` <20170126182753.GA5056-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-26 20:38                       ` Hefty, Sean
     [not found]                         ` <1828884A29C6694DAF28B7E6B8A82373AB0E132B-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-01-26 21:49                           ` Jason Gunthorpe
2017-01-26 20:23                   ` Leon Romanovsky
     [not found]                     ` <20170126202330.GX6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-26 23:53                       ` Hefty, Sean
     [not found]                         ` <1828884A29C6694DAF28B7E6B8A82373AB0E15AD-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-01-27  1:04                           ` Jason Gunthorpe
     [not found]                             ` <20170127010452.GA7826-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-27  1:17                               ` Hefty, Sean
     [not found]                                 ` <1828884A29C6694DAF28B7E6B8A82373AB0E1609-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-01-27 14:32                                   ` Doug Ledford
     [not found]                                     ` <41e74ed7-fd8d-89cf-2c79-b99a8d786fac-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-27 16:22                                       ` Jason Gunthorpe
2017-01-31 18:37                                       ` Coulter, Susan K
     [not found]                                         ` <A4803088-726E-4B88-B421-CE1969B6E25B-K3XgeB3KlJxL3NSqSJqx7PIbXMQ5te18@public.gmane.org>
2017-01-31 20:37                                           ` Christoph Hellwig
2017-01-27 21:16                               ` Weiny, Ira
2017-01-31 12:23           ` Benjamin Drung
     [not found]             ` <1485865383.4257.10.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-01-31 15:06               ` Benjamin Drung
     [not found]                 ` <1485875171.4257.18.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-01-31 17:35                   ` Jason Gunthorpe
2017-01-31 16:38               ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126180926.GB20330@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox