From: Dan Carpenter <dan.carpenter@oracle.com>
To: Doug Ledford <dledford@redhat.com>
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"sean.hefty@intel.com" <sean.hefty@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] IB/cma: Fix reversed test
Date: Sat, 28 Jan 2017 09:59:27 +0300 [thread overview]
Message-ID: <20170128065927.GP4149@mwanda> (raw)
In-Reply-To: <1485561952.2432.31.camel@redhat.com>
On Fri, Jan 27, 2017 at 07:05:52PM -0500, Doug Ledford wrote:
> > Do you think this patch needs "Fixes:" and "Cc: stable" tags?
>
> It does not.
We always should have fixes tags.
When I'm reviewing, I try to look up the patch which introduced the bug
so I can figure out what the intent was. Having a Fixes tag speeds up
my work.
Looking at how the bug was introduced sometimes helps to prevent bugs
from recurring in the future. For example, I've seen several bugs
introduced because the right people weren't on the CC to review it. For
this particular bug it feels like probably this bug could have been
detected with more testing. I doubt it would have made it into a
released kernel.
Also it let's you CC the original authors and hopefully they can Ack it.
regards,
dan carpenter
next prev parent reply other threads:[~2017-01-28 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 13:15 [PATCH] IB/cma: Fix reversed test Christophe JAILLET
2017-01-27 19:24 ` Doug Ledford
2017-01-27 21:31 ` Bart Van Assche
[not found] ` <1485552696.13218.0.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-28 0:05 ` Doug Ledford
2017-01-28 6:59 ` Dan Carpenter [this message]
2017-01-28 12:47 ` Majd Dibbiny
2017-01-28 13:01 ` Majd Dibbiny
2017-02-03 18:34 ` Doug Ledford
[not found] ` <2fde1e87-a345-4697-e205-051a3973e624-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-06 9:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128065927.GP4149@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox