Re: [PATCH rdma-core 01/11] libbnxtre: introduce bnxtre user space RDMA provider

Jason Gunthorpe
2017-01-29T23:05:46Z

On Sat, Jan 28, 2017 at 05:13:32PM -0500, Devesh Sharma wrote:
> add_subdirectory(providers/ocrdma)
> add_subdirectory(providers/qedr)
> add_subdirectory(providers/vmw_pvrdma)
> +add_subdirectory(providers/bnxtre)
> endif()

Keep list sorted

>
> add_subdirectory(providers/hfi1verbs)
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2ae504c..f52da1c 100644
> +++ b/MAINTAINERS
> @@ -166,3 +166,8 @@ M: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
> L: pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
> S: Supported
> F: providers/vmw_pvrdma/
> +
> +BNXTRE USERSPACE PROVIDER (for bnxtre.ko)
> +M: Devesh Sharma <Devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> +S: Supported
> +F: providers/bnxtre

Keep list sorted

> diff --git a/providers/bnxtre/bnxtre.driver b/providers/bnxtre/bnxtre.driver
> new file mode 100644
> index 0000000..5ce796f
> +++ b/providers/bnxtre/bnxtre.driver
> @@ -0,0 +1 @@
> +driver bnxtre

No, delete this file

> +#if HAVE_CONFIG_H
> +#include <config.h>
> +#endif /* HAVE_CONFIG_H */

HAVE_CONFIG_H is not defined in our builds, do not use config.h if we
don't need it. Ditto everywhere

> +struct {
> + unsigned int vendor;
> + unsigned int device;
> +} cna_table[] = {

static const?

Jason