Re: [PATCH rdma-core 00/11] Broadcom User Space RoCE Driver

Doug Ledford
2017-01-29T02:24:19Z

[-- Attachment #1: Type: text/plain, Size: 3103 bytes --]

On Sat, 2017-01-28 at 17:13 -0500, Devesh Sharma wrote:
> This series introduces the user space RoCE driver for the Broadcom
> NetXtreme-E 10/25/40/50 RDMA Ethernet Controller. This driver
> is dependent on the bnxt_re driver posted earlier to linux-rdma
> community and is under reveiw.
>
> This patch series is based on the latest master of rdma-core
> repository hosted at https://github.com/linux-rdma/rdma-core.git
>
> The GIT for this library is hosted at following URL on github
> https://github.com/dsharma283/bnxtre-rdma-core.git
> branch: bnxtre-v0
>
> Please review and give your feedback.

Not a complete review, just noting that you did the same thing about
not being consistent with your name.  It should be libbnxt_re to match
the kernel module name.

> Devesh Sharma (11):
>   libbnxtre: introduce bnxtre user space RDMA provider
>   libbnxtre: Add support for user memory regions
>   libbnxtre: Add support for CQ and QP management
>   libbnxtre: Add support for posting and polling
>   libbnxtre: Allow apps to poll for flushed completions
>   libbnxtre: convert cpu to le all over the place
>   libbnxtre: Enable UD control path and wqe posting
>   libbnxtre: Enable polling for UD completions
>   libbnxtre: Add support for atomic operations
>   libbnxtre: Add support for SRQ in user lib
>   libbnxtre: Add versioning support
>
>  CMakeLists.txt                  |    1 +
>  MAINTAINERS                     |    5 +
>  providers/bnxtre/CMakeLists.txt |    6 +
>  providers/bnxtre/abi.h          |  418 ++++++++++
>  providers/bnxtre/bnxtre.driver  |    1 +
>  providers/bnxtre/db.c           |  110 +++
>  providers/bnxtre/list.h         |  135 ++++
>  providers/bnxtre/main.c         |  220 ++++++
>  providers/bnxtre/main.h         |  358 +++++++++
>  providers/bnxtre/memory.c       |   77 ++
>  providers/bnxtre/memory.h       |  160 ++++
>  providers/bnxtre/verbs.c        | 1597
> +++++++++++++++++++++++++++++++++++++++
>  providers/bnxtre/verbs.h        |  106 +++
>  providers/bnxtre/version.h      |   53 ++
>  14 files changed, 3247 insertions(+)
>  create mode 100644 providers/bnxtre/CMakeLists.txt
>  create mode 100644 providers/bnxtre/abi.h
>  create mode 100644 providers/bnxtre/bnxtre.driver
>  create mode 100644 providers/bnxtre/db.c
>  create mode 100644 providers/bnxtre/list.h
>  create mode 100644 providers/bnxtre/main.c
>  create mode 100644 providers/bnxtre/main.h
>  create mode 100644 providers/bnxtre/memory.c
>  create mode 100644 providers/bnxtre/memory.h
>  create mode 100644 providers/bnxtre/verbs.c
>  create mode 100644 providers/bnxtre/verbs.h
>  create mode 100644 providers/bnxtre/version.h
>
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD

Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]