Re: [PATCH rdma-core 09/11] libbnxtre: Add support for atomic operations

Jason Gunthorpe
2017-01-29T23:46:02Z

On Sat, Jan 28, 2017 at 05:13:40PM -0500, Devesh Sharma wrote:

> +#define upper_32_bits(n) ((__u32)(((n) >> 16) >> 16))

This can be >> 16

> +#define lower_32_bits(n) ((__u32)((n) & 0xFFFFFFFFUL))

Do not define macros as functions. Use static inline instead.

Jason