Re: [PATCH rdma-core V1 2/2] travis: Upload assets to github release

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]

On Mon, Jan 30, 2017 at 10:09:56AM -0700, Jason Gunthorpe wrote:
> On Mon, Jan 30, 2017 at 08:23:16AM +0200, Leon Romanovsky wrote:
>
> > +  # Deploy assets to Github releases
> > +  # https://docs.travis-ci.com/user/deployment/releases/
> > +  provider: releases
> > +  api_key:
> > +    # This is encrypted OAth token generated by
> > +    # Travis CLI tool (travis setup releases) limited to specific repo.
> > +    secure: G9sQd578nctgaety6f27P4p5nyrEgXdvMs1g+K2Hj7GPWxBpQ1Jm7kUlahcwfnYXpYqXen9b2dzyGzaLxjLL5rv6rbtOYp9SVrvybQrnJwkB0HCERKVMwEPsLPOB2lMouBDfk4+iUGdxtcw8Y5UU/xqKcAjkHkM5YpF5HauEX1Jj+Ep/XpX5DEcsVmFwkDgPKJOZv/eUgz1eVtXNFIvmSwJ+QuuUz64JpEpKMY4u7bFu0+2qWqACj19P/Rnufxpr+o5yoCuVNVptoRHMIWJiWZsrd2IhmL3knBoPoxNXSOWqQCK6DCW1KYOOVVAfFoD4YWhWrt6MuB3hh7lgLkS0rsdG9+iMlosl4SOkWZF8ZTkmrmtt6yx+s18tFdNI46QKzaA4wS/1hktweIFizYvmEwUCU8sNK5y9PMfDoGJGwiF1FzWrnLItKMiib0sTGO4Umgc0DKTazVRlIJYooOOOnBGubRudNx3elBTy4C/txSmqR39/6GYlvcyUDJMqB/oQJj2erQ5Gu8VykW5zjko6+3miX3C7GFVQ781BLxAdyNl4WRjZ9ibzjMbK3MC7f0ho1hST6cvBBmy2UnIdvB6zMayHZ/gtXKsDqE386k5FwSuTLT2V7942uFRVJiEwhVmgmBzbZND7PTj4s9GPrL2HLlJOgZooRZdx/ZcT/YNPFbA=
>
> So this is a restricted oauth token for your github account then?

It is encrypted token, you can't use it without knowing how to decrypt it.
https://docs.travis-ci.com/user/encryption-keys/
https://docs.travis-ci.com/user/environment-variables/#Encrypted-Variables

>
> You are comfortable with this?

I'm fine with that.

>
> > +if [[ $TRAVIS_TAG == v* ]] && [ "$TRAVIS_OS_NAME" = "linux" ]; then
> > +	# Let's create release for vX tags only.
> > +	git archive --prefix rdma-core/ --output rdma-core-$TRAVIS_TAG.tar.gz HEAD
>
> Should be
>
> --prefix rdma-core-$TRAVIS_TAG/
>
> I think..

I have no opinion about that, because I'm not going to use this tar.gz file.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]