From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: Need to set if_index in ib_init_ah_from_wc() ? Date: Mon, 30 Jan 2017 18:49:41 -0700 Message-ID: <20170131014941.GA15387@obsidianresearch.com> References: <20170130195412.GE24466@obsidianresearch.com> <20170130211420.GB27111@obsidianresearch.com> <20170130221437.GA28117@obsidianresearch.com> <20170131005340.GA30809@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170131005340.GA30809-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Parav Pandit Cc: Roland Dreier , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Matan Barak List-Id: linux-rdma@vger.kernel.org On Mon, Jan 30, 2017 at 05:53:40PM -0700, Jason Gunthorpe wrote: > In IB the matching GID table entry is placed in wc.sgid_index. > > I argued that rocee should do the same, but since mlx didn't implement > this in hardware they didn't want to take the performance cost when > building the WC. Sorry, I realized this reads confusingly after the fact - the argument was about adding a wc.gid_index - IB unambigously open-codes computing wc.gid_index .. I think you should review the thread starting here: http://www.spinics.net/lists/linux-rdma/msg30976.html Which is what caused this broken route lookup to be implemented in the first place. And here is my first suggestion on how to fix it up: http://www.spinics.net/lists/linux-rdma/msg31118.html The fact the fundamental problems I raised during the review were not properly addressed is what is causing these problems and confusion now. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html