[bug report] IB/cma: Add default RoCE TOS to CMA configfs

[bug report] IB/cma: Add default RoCE TOS to CMA configfs

[Dan Carpenter]

Hello Majd Dibbiny,

The patch eeec11e5c404: "IB/cma: Add default RoCE TOS to CMA
configfs" from Dec 19, 2016, leads to the following static checker
warning:

	drivers/infiniband/core/cma.c:303 cma_get_default_roce_tos()
	warn: signedness bug returning '(-22)'

drivers/infiniband/core/cma.c
   298  
   299  u8 cma_get_default_roce_tos(struct cma_device *cma_dev, unsigned int port)
   300  {
   301          if (port < rdma_start_port(cma_dev->device) ||
   302              port > rdma_end_port(cma_dev->device))
   303                  return -EINVAL;

This is a u8 function so you can't return negative error codes.

   304  
   305          return cma_dev->default_roce_tos[port - rdma_start_port(cma_dev->device)];
   306  }
   307  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [bug report] IB/cma: Add default RoCE TOS to CMA configfs

[Majd Dibbiny]

> On Jan 31, 2017, at 12:59 PM, Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> 
> Hello Majd Dibbiny,
Hello Daniel,

Thanks for the report.
I'll fix and send a new revision soon..

> 
> The patch eeec11e5c404: "IB/cma: Add default RoCE TOS to CMA
> configfs" from Dec 19, 2016, leads to the following static checker
> warning:
> 
>    drivers/infiniband/core/cma.c:303 cma_get_default_roce_tos()
>    warn: signedness bug returning '(-22)'
> 
> drivers/infiniband/core/cma.c
>   298  
>   299  u8 cma_get_default_roce_tos(struct cma_device *cma_dev, unsigned int port)
>   300  {
>   301          if (port < rdma_start_port(cma_dev->device) ||
>   302              port > rdma_end_port(cma_dev->device))
>   303                  return -EINVAL;
> 
> This is a u8 function so you can't return negative error codes.
> 
>   304  
>   305          return cma_dev->default_roce_tos[port - rdma_start_port(cma_dev->device)];
>   306  }
>   307  
> 
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [bug report] IB/cma: Add default RoCE TOS to CMA configfs

[Yuval Shaia]

On Tue, Jan 31, 2017 at 03:32:48PM +0000, Majd Dibbiny wrote:
> 
> > On Jan 31, 2017, at 12:59 PM, Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> > 
> > Hello Majd Dibbiny,
> Hello Daniel,
> 
> Thanks for the report.
> I'll fix and send a new revision soon..

Can you re-base it on top of for-next and use the new inline function
rdma_is_port_valid?

> 
> > 
> > The patch eeec11e5c404: "IB/cma: Add default RoCE TOS to CMA
> > configfs" from Dec 19, 2016, leads to the following static checker
> > warning:
> > 
> >    drivers/infiniband/core/cma.c:303 cma_get_default_roce_tos()
> >    warn: signedness bug returning '(-22)'
> > 
> > drivers/infiniband/core/cma.c
> >   298  
> >   299  u8 cma_get_default_roce_tos(struct cma_device *cma_dev, unsigned int port)
> >   300  {
> >   301          if (port < rdma_start_port(cma_dev->device) ||
> >   302              port > rdma_end_port(cma_dev->device))
> >   303                  return -EINVAL;
> > 
> > This is a u8 function so you can't return negative error codes.
> > 
> >   304  
> >   305          return cma_dev->default_roce_tos[port - rdma_start_port(cma_dev->device)];
> >   306  }
> >   307  
> > 
> > regards,
> > dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html