Re: [PATCH rdma-core 1/7] mlx5: Add mlx5 direct verbs files

Jason Gunthorpe
2017-01-26T17:27:42Z

On Thu, Jan 26, 2017 at 05:56:16PM +0200, Yishai Hadas wrote:

> +add_subdirectory(include)

No need for a subdirectory. I've been flattening things for a while

> +/* Always inline the function */
> +#ifdef __GNUC__
> +#define MLX5DV_ALWAYS_INLINE inline __attribute__((always_inline))
> +#else
> +#define MLX5DV_ALWAYS_INLINE inline
> +#endif

I doubt this is necessary... static inline is fine these days.

Jason