From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder
Date: Wed, 1 Feb 2017 10:25:18 -0800 [thread overview]
Message-ID: <20170201182518.GA32532@infradead.org> (raw)
In-Reply-To: <20170131185302.14185.10775.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
I'm always confused when a cleanup adds more line than it removes,
but it seems to be just comments in this case and some other
patches in the series.
> + * svc_rdma_xdr_encode_reply_header - Encode Reply's fixed header fields
> + * @rdma: controlling transport
> + * @rdma_argp: Call's transport header
> + * @rdma_resp: Reply's transport header
> + * @rdma_type: procedure number
> + *
> + */
> +void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *rdma,
> + __be32 *rdma_argp, __be32 *rdma_resp,
> + __be32 rdma_type)
To me it would seem much cleaner to just take the few lines of encoding
into the only caller.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-01 18:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:52 [PATCH v2 0/7] Server-side NFS/RDMA changes for v4.11 Chuck Lever
[not found] ` <20170131184623.14185.35480.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-01-31 18:52 ` [PATCH v2 1/7] svcrdma: Another sendto chunk list parsing update Chuck Lever
2017-01-31 18:53 ` [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder Chuck Lever
[not found] ` <20170131185302.14185.10775.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:25 ` Christoph Hellwig [this message]
[not found] ` <20170201182518.GA32532-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-01 19:39 ` Chuck Lever
2017-01-31 18:53 ` [PATCH v2 3/7] svcrdma: Clean up RPC-over-RDMA Call header decoder Chuck Lever
[not found] ` <20170131185310.14185.76931.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:28 ` Christoph Hellwig
2017-01-31 18:53 ` [PATCH v2 4/7] svcrdma: Clean up backchannel send header encoding Chuck Lever
[not found] ` <20170131185318.14185.90053.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:29 ` Christoph Hellwig
[not found] ` <20170201182957.GC32532-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-01 19:48 ` Chuck Lever
2017-01-31 18:53 ` [PATCH v2 5/7] svcrdma: Remove unused sc_dto_q field Chuck Lever
[not found] ` <20170131185326.14185.48454.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:30 ` Christoph Hellwig
2017-01-31 18:53 ` [PATCH v2 6/7] svcrdma: Combine list fields in struct svc_rdma_op_ctxt Chuck Lever
[not found] ` <20170131185335.14185.80060.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:30 ` Christoph Hellwig
2017-01-31 18:53 ` [PATCH v2 7/7] svcrdma: Poll CQs in "workqueue" mode Chuck Lever
[not found] ` <20170131185343.14185.76984.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:31 ` Christoph Hellwig
2017-02-06 22:39 ` [PATCH v2 0/7] Server-side NFS/RDMA changes for v4.11 J. Bruce Fields
[not found] ` <20170206223918.GE19704-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2017-02-06 22:48 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201182518.GA32532@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox