qedr and vmw_pvrdma are not packaged in rdma-core

qedr and vmw_pvrdma are not packaged in rdma-core

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi Ram and Adit,

I want to bring to your attention that qedr and vmw_pvrdma drivers are
missing from various package files available in rdma-core.

Can you please send the patches which add your drivers to rdma-core
packages (Redhat and Debian)?

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Christoph Hellwig]

On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> Hi Ram and Adit,
> 
> I want to bring to your attention that qedr and vmw_pvrdma drivers are
> missing from various package files available in rdma-core.
> 
> Can you please send the patches which add your drivers to rdma-core
> packages (Redhat and Debian)?

Even better: can we find a way so that providers (old and new) get added
automatically?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Benjamin Drung]

Am Donnerstag, den 02.02.2017, 00:13 -0800 schrieb Christoph Hellwig:
> On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> > Hi Ram and Adit,
> > 
> > I want to bring to your attention that qedr and vmw_pvrdma drivers
> > are
> > missing from various package files available in rdma-core.
> > 
> > Can you please send the patches which add your drivers to rdma-core
> > packages (Redhat and Debian)?
> 
> Even better: can we find a way so that providers (old and new) get
> added automatically?

debian/ibverbs-providers.install specifies:
usr/lib/*/libibverbs/lib*-rdmav2.so

So if CMake installs the provider, the package will automatically pick
it up.

-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
URL:  http://www.profitbricks.com

Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
Geschäftsführer: Andreas Gauger, Achim Weiss.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Thu, Feb 02, 2017 at 10:17:56AM +0100, Benjamin Drung wrote:
> Am Donnerstag, den 02.02.2017, 00:13 -0800 schrieb Christoph Hellwig:
> > On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> > > Hi Ram and Adit,
> > >
> > > I want to bring to your attention that qedr and vmw_pvrdma drivers
> > > are
> > > missing from various package files available in rdma-core.
> > >
> > > Can you please send the patches which add your drivers to rdma-core
> > > packages (Redhat and Debian)?
> >
> > Even better: can we find a way so that providers (old and new) get
> > added automatically?
>
> debian/ibverbs-providers.install specifies:
> usr/lib/*/libibverbs/lib*-rdmav2.so
>
> So if CMake installs the provider, the package will automatically pick
> it up.

RedHat has different scheme with explicit declaration, from redhat/rdma-core.spec
 98 Provides: librxe = %{version}-%{release}
 99 Obsoletes: librxe < %{version}-%{release}

But it is not installation only.
for example debian/copyright doesn't have information about
providers/vmw_pvrdma.

>
> --
> Benjamin Drung
> System Developer
> Debian & Ubuntu Developer
>
> ProfitBricks GmbH
> Greifswalder Str. 207
> D - 10405 Berlin
>
> Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
> URL:  http://www.profitbricks.com
>
> Sitz der Gesellschaft: Berlin.
> Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
> Geschäftsführer: Andreas Gauger, Achim Weiss.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Jason Gunthorpe]

On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> Hi Ram and Adit,
> 
> I want to bring to your attention that qedr and vmw_pvrdma drivers are
> missing from various package files available in rdma-core.

It is handled automatically, can't be missing:

$ buildlib/cbuild pkg jessie
$ dpkg-deb -c ../ibverbs-providers_13-1_amd64.deb
-rw-r--r-- root/root     35024 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libqedr-rdmav2.so
-rw-r--r-- root/root     18600 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libvmw_pvrdma-rdmav2.so

$ buildlib/cbuild pkg fc25
$ rpm -q -l -p ../libibverbs-13-1.fc25.x86_64.rpm
/usr/lib64/libibverbs/libqedr-rdmav2.so
/usr/lib64/libibverbs/libvmw_pvrdma-rdmav2.so

> RedHat has different scheme with explicit declaration, from redhat/rdma-core.spec
> 98 Provides: librxe = %{version}-%{release}
> 99 Obsoletes: librxe < %{version}-%{release}

This is only for things that were previously packaged in redhat, qedr
and vmw_pvrdma have not been, so they should not include those
stanzas. It is similar to the obsoletes/replaces in debian/control.

> But it is not installation only.  for example debian/copyright
> doesn't have information about providers/vmw_pvrdma.

Yes, this needs to be fixed..

This is why I was hoping for an automatic script to maintain this file :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

On Thu, Feb 02, 2017 at 09:38:31AM -0700, Jason Gunthorpe wrote:
> On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> > Hi Ram and Adit,
> >
> > I want to bring to your attention that qedr and vmw_pvrdma drivers are
> > missing from various package files available in rdma-core.
>
> It is handled automatically, can't be missing:
>
> $ buildlib/cbuild pkg jessie
> $ dpkg-deb -c ../ibverbs-providers_13-1_amd64.deb
> -rw-r--r-- root/root     35024 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libqedr-rdmav2.so
> -rw-r--r-- root/root     18600 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libvmw_pvrdma-rdmav2.so
>
> $ buildlib/cbuild pkg fc25
> $ rpm -q -l -p ../libibverbs-13-1.fc25.x86_64.rpm
> /usr/lib64/libibverbs/libqedr-rdmav2.so
> /usr/lib64/libibverbs/libvmw_pvrdma-rdmav2.so
>
> > RedHat has different scheme with explicit declaration, from redhat/rdma-core.spec
> > 98 Provides: librxe = %{version}-%{release}
> > 99 Obsoletes: librxe < %{version}-%{release}
>
> This is only for things that were previously packaged in redhat, qedr
> and vmw_pvrdma have not been, so they should not include those
> stanzas. It is similar to the obsoletes/replaces in debian/control.

Are you sure? I can't find librxe here.
https://www.rpmfind.net/linux/rpm2html/search.php?query=librxe&submit=Search+...&system=&arch=

>
> > But it is not installation only.  for example debian/copyright
> > doesn't have information about providers/vmw_pvrdma.
>
> Yes, this needs to be fixed..
>
> This is why I was hoping for an automatic script to maintain this file :)
>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: qedr and vmw_pvrdma are not packaged in rdma-core

[Jason Gunthorpe]

On Thu, Feb 02, 2017 at 07:44:15PM +0200, Leon Romanovsky wrote:
> On Thu, Feb 02, 2017 at 09:38:31AM -0700, Jason Gunthorpe wrote:
> > On Thu, Feb 02, 2017 at 08:26:28AM +0200, Leon Romanovsky wrote:
> > > Hi Ram and Adit,
> > >
> > > I want to bring to your attention that qedr and vmw_pvrdma drivers are
> > > missing from various package files available in rdma-core.
> >
> > It is handled automatically, can't be missing:
> >
> > $ buildlib/cbuild pkg jessie
> > $ dpkg-deb -c ../ibverbs-providers_13-1_amd64.deb
> > -rw-r--r-- root/root     35024 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libqedr-rdmav2.so
> > -rw-r--r-- root/root     18600 2017-02-02 09:31 ./usr/lib/x86_64-linux-gnu/libibverbs/libvmw_pvrdma-rdmav2.so
> >
> > $ buildlib/cbuild pkg fc25
> > $ rpm -q -l -p ../libibverbs-13-1.fc25.x86_64.rpm
> > /usr/lib64/libibverbs/libqedr-rdmav2.so
> > /usr/lib64/libibverbs/libvmw_pvrdma-rdmav2.so
> >
> > > RedHat has different scheme with explicit declaration, from redhat/rdma-core.spec
> > > 98 Provides: librxe = %{version}-%{release}
> > > 99 Obsoletes: librxe < %{version}-%{release}
> >
> > This is only for things that were previously packaged in redhat, qedr
> > and vmw_pvrdma have not been, so they should not include those
> > stanzas. It is similar to the obsoletes/replaces in debian/control.
> 
> Are you sure? I can't find librxe here.
> https://www.rpmfind.net/linux/rpm2html/search.php?query=librxe&submit=Search+...&system=&arch=

Yes, I am sure.

Someone got overzealous then, the provides should be removed.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html