public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Bodong Wang <bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-rc] RDMA: Remove kernel private defines and reference to header from UAPI
Date: Wed, 8 Feb 2017 16:52:48 +0200	[thread overview]
Message-ID: <20170208145248.GE6005@mtr-leonro.local> (raw)
In-Reply-To: <20170208115349.GA18879-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Wed, Feb 08, 2017 at 03:53:49AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 08, 2017 at 12:00:43PM +0200, Leon Romanovsky wrote:
> > These constants are part of much larger enum ib_qp_attr_mask. IMHO copy
> > two values from that enum isn't good, but copy whole enum (mostly not
> > needed for the users) is bad either. So I decided to open code it as a fix
> > for -rc7.
>
> At least add comments mentioning the proper symbolic values then.

Sure, I'll send an update.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-02-08 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 17:46 [PATCH rdma-rc] RDMA: Remove kernel private defines and reference to header from UAPI Leon Romanovsky
     [not found] ` <20170207174600.27218-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-08  8:26   ` Sl Sh
2017-02-08  8:28   ` Christoph Hellwig
     [not found]     ` <20170208082850.GA11087-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-08 10:00       ` Leon Romanovsky
     [not found]         ` <20170208100043.GC6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-08 11:53           ` Christoph Hellwig
     [not found]             ` <20170208115349.GA18879-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-08 14:52               ` Leon Romanovsky [this message]
2017-02-08 12:33           ` Matan Barak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208145248.GE6005@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox