Re: [PATCH V5 for-next 10/21] RDMA/bnxt_re: Support for CQ verbs

Leon Romanovsky
2017-02-14T12:22:12Z

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Fri, Feb 10, 2017 at 03:19:42AM -0800, Selvin Xavier wrote:
> Implements support for create_cq, destroy_cq and req_notify_cq
> verbs.
>
> v3: Code cleanup based on errors reported by sparse on endianness check.
> Removes unwanted macros.
> v5: Use min_t macro to calculate the CQ entries
>
> Signed-off-by: Eddie Wai <eddie.wai@broadcom.com>
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---

<...>

> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.h b/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> index 78e1717..1dfc86d 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> @@ -38,6 +38,52 @@
>
> #ifndef __BNXT_QPLIB_FP_H__
> #define __BNXT_QPLIB_FP_H__
> +#define BNXT_QPLIB_MAX_CQE_ENTRY_SIZE sizeof(struct cq_base)
> +

IMHO, this define is redundant.
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]