Re: [PATCH V5 for-next 21/21] RDMA/bnxt_re: Add bnxt_re driver build support

Leon Romanovsky
2017-02-12T07:54:49Z

[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]

On Fri, Feb 10, 2017 at 03:19:53AM -0800, Selvin Xavier wrote:
> Makefile and Kconfig changes for enabling bnxt_re compilation
>
> v3: Adds list of MAINTAINERS of bnxt_re driver. Removes bnxt_re_debugfs.c
> from Makefile as this file is no longer present
>
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> MAINTAINERS | 11 +++++++++++
> drivers/infiniband/Kconfig | 2 ++
> drivers/infiniband/hw/Makefile | 1 +
> drivers/infiniband/hw/bnxt_re/Kconfig | 9 +++++++++
> drivers/infiniband/hw/bnxt_re/Makefile | 6 ++++++
> 5 files changed, 29 insertions(+)
> create mode 100644 drivers/infiniband/hw/bnxt_re/Kconfig
> create mode 100644 drivers/infiniband/hw/bnxt_re/Makefile
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5f0420a..468d2e8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2808,6 +2808,17 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> F: arch/arm64/boot/dts/broadcom/vulcan*
>
> +BROADCOM NETXTREME-E ROCE DRIVER
> +M: Selvin Xavier <selvin.xavier@broadcom.com>
> +M: Devesh Sharma <devesh.sharma@broadcom.com>
> +M: Somnath Kotur <somnath.kotur@broadcom.com>
> +M: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> +L: linux-rdma@vger.kernel.org
> +W: http://www.broadcom.com
> +S: Supported
> +F: drivers/infiniband/hw/bnxt_re/
> +F: include/uapi/rdma/bnxt_re-abi.h
> +

Please take a look on the note which I gave to Faisal a long time ago [1].
Our experience shows that the more people you add here, the less chances
to be CCed on the relevant patches.

It is definitely up to you.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[1] https://www.spinics.net/lists/linux-rdma/msg41457.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]