From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V1 rdma-core 6/7] mlx5: Add direct verbs man pages
Date: Mon, 13 Feb 2017 14:59:10 -0700 [thread overview]
Message-ID: <20170213215910.GA16726@obsidianresearch.com> (raw)
In-Reply-To: <156c0448-5e9b-9879-1d6b-06cbaec3ce6b-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Mon, Feb 13, 2017 at 11:52:33PM +0200, Yishai Hadas wrote:
> There is nothing wrong with current usage of comp_mask, it just
> follows the usage of ibv_query_rt_values_ex where it's used as both
> in/out.(see below from its man page) We can update the man pages to
> say it explicitly so that it will be fully clear.
And I complained about that when you did it too - it is still *horrible*
> That way looks quite more simple than managing an input size which may still
> require a comp_mask as an output to mark which values were set in case few
> fields can have a valid value of 0 but might be ignored as of legacy driver.
The best is to just have unique functions or a sane multiplexor, stop
copying this bad idea.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-13 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 14:16 [PATCH V1 rdma-core 0/7] Add mlx5 direct verbs Yishai Hadas
[not found] ` <1486909012-15064-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-02-12 14:16 ` [PATCH V1 rdma-core 1/7] mlx5: " Yishai Hadas
2017-02-12 14:16 ` [PATCH V1 rdma-core 2/7] mlx5: Add CQE fields Yishai Hadas
2017-02-12 14:16 ` [PATCH V1 rdma-core 3/7] mlx5: Add WQE segments implementation Yishai Hadas
2017-02-12 14:16 ` [PATCH V1 rdma-core 4/7] mlx5: Use macro for CQE version 1 Yishai Hadas
2017-02-12 14:16 ` [PATCH V1 rdma-core 5/7] mlx5: Convert to use predefined get CQE opcodes Yishai Hadas
2017-02-12 14:16 ` [PATCH V1 rdma-core 6/7] mlx5: Add direct verbs man pages Yishai Hadas
[not found] ` <1486909012-15064-7-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-02-13 16:54 ` Jason Gunthorpe
[not found] ` <20170213165445.GC25430-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-13 18:13 ` Leon Romanovsky
[not found] ` <20170213181338.GB6989-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-13 18:45 ` Jason Gunthorpe
[not found] ` <20170213184551.GB12224-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-13 21:52 ` Yishai Hadas
[not found] ` <156c0448-5e9b-9879-1d6b-06cbaec3ce6b-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-02-13 21:59 ` Jason Gunthorpe [this message]
2017-02-12 14:16 ` [PATCH V1 rdma-core 7/7] mlx5: Export mlx5 direct verbs interface Yishai Hadas
[not found] ` <1486909012-15064-8-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-02-13 16:49 ` Jason Gunthorpe
[not found] ` <20170213164944.GB25430-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-13 18:21 ` Leon Romanovsky
[not found] ` <20170213182121.GD6989-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-13 18:42 ` Jason Gunthorpe
[not found] ` <20170213184250.GA12224-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-14 5:52 ` Leon Romanovsky
[not found] ` <20170214055219.GE6989-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-14 18:05 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213215910.GA16726@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox