From: Leon Romanovsky <leon@kernel.org>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, Eddie Wai <eddie.wai@broadcom.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH V5 for-next 10/21] RDMA/bnxt_re: Support for CQ verbs
Date: Tue, 14 Feb 2017 14:22:12 +0200 [thread overview]
Message-ID: <20170214122212.GJ6989@mtr-leonro.local> (raw)
In-Reply-To: <1486725593-9872-11-git-send-email-selvin.xavier@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Fri, Feb 10, 2017 at 03:19:42AM -0800, Selvin Xavier wrote:
> Implements support for create_cq, destroy_cq and req_notify_cq
> verbs.
>
> v3: Code cleanup based on errors reported by sparse on endianness check.
> Removes unwanted macros.
> v5: Use min_t macro to calculate the CQ entries
>
> Signed-off-by: Eddie Wai <eddie.wai@broadcom.com>
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
<...>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.h b/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> index 78e1717..1dfc86d 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.h
> @@ -38,6 +38,52 @@
>
> #ifndef __BNXT_QPLIB_FP_H__
> #define __BNXT_QPLIB_FP_H__
> +#define BNXT_QPLIB_MAX_CQE_ENTRY_SIZE sizeof(struct cq_base)
> +
IMHO, this define is redundant.
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-14 12:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 11:19 [PATCH V5 for-next 00/21] Broadcom RoCE Driver (bnxt_re) Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 01/21] RDMA/bnxt_re: Add bnxt_re RoCE driver files Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 04/21] RDMA/bnxt_re: Enabling RoCE control path Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 05/21] RDMA/bnxt_re: Adding Notification Queue support Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 06/21] RDMA/bnxt_re: Support for PD, ucontext and mmap verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 07/21] RDMA/bnxt_re: Support for query and modify device verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 09/21] RDMA/bnxt_re: Support for GID related verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 10/21] RDMA/bnxt_re: Support for CQ verbs Selvin Xavier
2017-02-14 12:22 ` Leon Romanovsky [this message]
2017-02-10 11:19 ` [PATCH V5 for-next 11/21] RDMA/bnxt_re: Support for AH verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 12/21] RDMA/bnxt_re: Support memory registration verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 13/21] RDMA/bnxt_re: Support QP verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 14/21] RDMA/bnxt_re: Support post_send verb Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 15/21] RDMA/bnxt_re: Support post_recv Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 19/21] RDMA/bnxt_re: Set uverbs command mask Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 20/21] RDMA/bnxt_re: Add QP event handling Selvin Xavier
[not found] ` <1486725593-9872-1-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-02-10 11:19 ` [PATCH V5 for-next 02/21] RDMA/bnxt_re: Introducing autogenerated Host Software Interface(hsi) file Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 03/21] RDMA/bnxt_re: register with the NIC driver Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 08/21] RDMA/bnxt_re: Adding support for port related verbs Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb Selvin Xavier
[not found] ` <1486725593-9872-17-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-02-12 14:30 ` Leon Romanovsky
[not found] ` <20170212143051.GD14015-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-13 5:17 ` Selvin Xavier
[not found] ` <CA+sbYW36txPueFBWFOWigHu_XmnTPY+-Vdu5MmGeOQ7uFjrWag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-13 5:45 ` Leon Romanovsky
2017-02-10 11:19 ` [PATCH V5 for-next 18/21] RDMA/bnxt_re: Support for DCB Selvin Xavier
2017-02-10 11:19 ` [PATCH V5 for-next 21/21] RDMA/bnxt_re: Add bnxt_re driver build support Selvin Xavier
2017-02-12 7:54 ` Leon Romanovsky
2017-03-02 14:57 ` [PATCH V5 for-next 00/21] Broadcom RoCE Driver (bnxt_re) Or Gerlitz
2017-03-02 15:01 ` Devesh Sharma
[not found] ` <CANjDDBg_QoSwHMqjUOr2UrobaBHwyfrHzzK8N7VXcmq1eEONSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-02 15:48 ` Or Gerlitz
2017-03-02 15:08 ` Leon Romanovsky
2017-02-14 14:59 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214122212.GJ6989@mtr-leonro.local \
--to=leon@kernel.org \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=eddie.wai@broadcom.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox