Re: [PATCH v2 7/8] IB/core: Add support for draining IB_POLL_DIRECT completion queues

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

On Tue, Feb 14, 2017 at 10:56:35AM -0800, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Cc: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> Cc: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/infiniband/core/cq.c    |  4 ++--
>  drivers/infiniband/core/verbs.c | 35 +++++++++++++++--------------------
>  2 files changed, 17 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/infiniband/core/cq.c b/drivers/infiniband/core/cq.c
> index a754fc727de5..48242785b323 100644
> --- a/drivers/infiniband/core/cq.c
> +++ b/drivers/infiniband/core/cq.c
> @@ -58,8 +58,8 @@ static int __ib_process_cq(struct ib_cq *cq, int budget)
>   * %IB_POLL_DIRECT CQ.  It does not offload CQ processing to a different
>   * context and does not ask for completion interrupts from the HCA.
>   *
> - * Note: for compatibility reasons -1 can be passed in %budget for unlimited
> - * polling.  Do not use this feature in new code, it will be removed soon.
> + * Note: do not pass -1 as %budget unless it is guaranteed that the number
> + * of completions that will be processed is small.
>   */

Interesting solution.

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]