From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH v2 1/8] IB/SRP: Avoid using IB_MR_TYPE_SG_GAPS Date: Thu, 16 Feb 2017 08:14:59 +0200 Message-ID: <20170216061459.GV6989@mtr-leonro.local> References: <20170214185636.29250-1-bart.vanassche@sandisk.com> <20170214185636.29250-2-bart.vanassche@sandisk.com> <1557361565.31861655.1487176647067.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ayym4vmyMU9P4uDb" Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Sagi Grimberg Cc: Laurence Oberman , Bart Van Assche , Doug Ledford , linux-rdma@vger.kernel.org, Israel Rukshin , Max Gurtovoy , Mark Bloch , Yuval Shaia , "# 4 . 7+" List-Id: linux-rdma@vger.kernel.org --Ayym4vmyMU9P4uDb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 15, 2017 at 06:55:52PM +0200, Sagi Grimberg wrote: > > > Started with Linus's tree, applied the change requested by Sagi, built the kernel, rebooted and started the tests. > > > > Linux ibclient 4.10.0-rc8.sagi+ #1 SMP Wed Feb 15 11:09:44 EST 2017 x86_64 x86_64 x86_64 GNU/Linux > > > > Very quickly get to this > > > > [ 180.990285] mlx5_0:dump_cqe:262:(pid 0): dump error cqe > > [ 181.016899] 00000000 00000000 00000000 00000000 > > [ 181.040949] 00000000 00000000 00000000 00000000 > > [ 181.066960] 00000000 00000000 00000000 00000000 > > [ 181.092030] 00000000 0f007806 2500002a bf1913d0 > > [ 181.117254] scsi host2: ib_srp: failed FAST REG status memory management operation error (6) for CQE ffff880bdbe88778 > > [ 196.288933] fast_io_fail_tmo expired for SRP port-2:1 / host2. > > [ 197.090886] scsi host2: ib_srp: reconnect succeeded > > [ 197.127628] scsi host2: ib_srp: failed RECV status WR flushed (5) for CQE ffff8817f09b6f30 > > > > So does not help. > > I think my and Barts suggestion to revert for now is the best way forward. > > I have already tested this in-depth from Bart's tree and its been sent to Doug as V2 of Bart'recent 8 patch series. > > Yea, probably this is the best way forward. > > Bart, I think the change I suggested is still needed regardless, > do you agree? > > Max, Leon, is it possible that the max number of klms pr mr is > less than what reported in device capabilities for page_list_len? I hope no and we will check. I already asked it, but didn't get any response, and I'll repeat it again. ISER has similar code with SG_GAPS, does it work? > > If so, this means that either: > 1. mlx5 needs to expose the minimum between pages and sg elems (sucks) > 2. we need yet another capability for SG_GAPS (sucks^2 because the > whole point was to make it transparent to the user) > 3. mlx5 does not support SG_GAPS (sucks^3 because we now have something > thats not supported by any device). > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --Ayym4vmyMU9P4uDb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlilQ2MACgkQ5GN7iDZy WKefTg//ZPMrPxFA+Wn/wrFoip7c52Fs7qA+OseJTB/vNVtrKVHBuj73NVOgblOA hf9QbcXxLV1iZi7jakX5iqMAPHw4pMq/5c735aXKg7+HxAzVuCFkIwAsA2VF1ZeL Nynlg9iL1ZfPQVmmatE/zlKrjPtUIxM3Zd7DB91elXvJS0g6vxblU6E5ykUj66YA 4MmiR+NM7iyRdp+vS9cxcHDQmYvupn72JowIkgYQ6nEPJE4f8WujkPTjRMh/eaBH 3004AY5j+hYgSWQzJTRX59VifM5+R25H1vbCdgvFsUMCP7WdAUs3NXSIXwc2bVEk H1pVtutol06gI54h1ZkgNDHyIqVmxxWO3sEwhIiYqcnoEHbxOjHMly408JCojXGp i7p2f98uyZ6trtE9HliM9FTAc8W7FmLWMMQkt9EIQaG7hDx48QS27E7n8qulmoBk Fzv5q05Rp4Zhc1Qtasgz7ZHtsdUHpokMgjbwDBoe3tTbSjaghpAhFzEciqWPQDP8 OmE5ILMhW1xSfTqy+Jb4X31E38P+V8JgN13LavJS3m028cn8pgo/HjlCc/WjPLMV C2GoemHog1OzskyR2VqiOyuEcBPOyhBfxP4hjBKev08MCi9qjZ1T2tZ1LjPbXSu9 wPhE9hQ2z6o++UtqytVk/AsUG1gKfkekUUdOdsHeEXuAAYC0WdU= =bh7l -----END PGP SIGNATURE----- --Ayym4vmyMU9P4uDb--