Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function

Alexandre Belloni
2017-02-21T11:37:04Z

Hi,

A small comment, you must always have a commit message. Even if it is
small.

On 20/02/2017 at 22:00:41 -0700, Logan Gunthorpe wrote:
> Signed-off-by: Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
> ---
> drivers/dax/dax.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index ed758b7..0d24822 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -701,12 +701,12 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region,
>
> /* device_initialize() so cdev can reference kobj parent */
> device_initialize(dev);
> + dev->devt = dev_t;
>
> cdev = &dax_dev->cdev;
> cdev_init(cdev, &dax_fops);
> cdev->owner = parent->driver->owner;
> - cdev->kobj.parent = &dev->kobj;
> - rc = cdev_add(&dax_dev->cdev, dev_t, 1);
> + rc = device_add_cdev(dev, cdev);
> if (rc)
> goto err_cdev;
>
> @@ -716,7 +716,6 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region,
> dax_dev->region = dax_region;
> kref_get(&dax_region->kref);
>
> - dev->devt = dev_t;
> dev->class = dax_class;
> dev->parent = parent;
> dev->groups = dax_attribute_groups;
> --
> 2.1.4
>

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.