* [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num()
@ 2017-02-23 10:40 Dan Carpenter
2017-02-26 14:26 ` Yuval Shaia
2017-03-25 1:11 ` Doug Ledford
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-02-23 10:40 UTC (permalink / raw)
To: Selvin Xavier
Cc: Devesh Sharma, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma, kernel-janitors
We want to return zero on success or negative error codes. The type
should be int and not u8.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index e06ad7250963..b1b075763eaa 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct ocrdma_dev *dev, u16 pd_id,
return 0;
}
-static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
+static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
bool dpp_pool)
{
int status;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num()
2017-02-23 10:40 [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num() Dan Carpenter
@ 2017-02-26 14:26 ` Yuval Shaia
2017-03-25 1:11 ` Doug Ledford
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Shaia @ 2017-02-26 14:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Thu, Feb 23, 2017 at 01:40:16PM +0300, Dan Carpenter wrote:
> We want to return zero on success or negative error codes. The type
> should be int and not u8.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index e06ad7250963..b1b075763eaa 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct ocrdma_dev *dev, u16 pd_id,
> return 0;
> }
>
> -static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
> +static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
> bool dpp_pool)
> {
> int status;
> --
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num()
2017-02-23 10:40 [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num() Dan Carpenter
2017-02-26 14:26 ` Yuval Shaia
@ 2017-03-25 1:11 ` Doug Ledford
1 sibling, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2017-03-25 1:11 UTC (permalink / raw)
To: Dan Carpenter, Selvin Xavier
Cc: Devesh Sharma, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Thu, 2017-02-23 at 13:40 +0300, Dan Carpenter wrote:
> We want to return zero on success or negative error codes. The type
> should be int and not u8.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index e06ad7250963..b1b075763eaa 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct
> ocrdma_dev *dev, u16 pd_id,
> return 0;
> }
>
> -static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
> +static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
> bool dpp_pool)
> {
> int status;
Thanks, applied for -rc.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-25 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 10:40 [patch] RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num() Dan Carpenter
2017-02-26 14:26 ` Yuval Shaia
2017-03-25 1:11 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).