From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 01/16] chardev: add helper function to register char devs with a struct device Date: Tue, 28 Feb 2017 06:31:02 +0100 Message-ID: <20170228053102.GA14688@kroah.com> References: <1488091097-12328-1-git-send-email-logang@deltatee.com> <1488091097-12328-2-git-send-email-logang@deltatee.com> <20170227165618.GE5891@obsidianresearch.com> <7df6e57b-531c-1b23-05bf-c368df2d20f3@deltatee.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Dan Williams Cc: Logan Gunthorpe , Jason Gunthorpe , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Hartmut Knaack , Lars-Peter Clausen List-Id: linux-rdma@vger.kernel.org On Mon, Feb 27, 2017 at 07:36:09PM -0800, Dan Williams wrote: > On Mon, Feb 27, 2017 at 7:27 PM, Logan Gunthorpe wrote: > > > > > > On 27/02/17 09:56 AM, Jason Gunthorpe wrote: > >> Yes please, that is way too subtle. Suggest: > >> > >> NOTE: Callers must assume that userspace was able to open the cdev and > >> can call cdev fops callbacks at any time, even if this function fails. > >> > >> I would also add a note to cdev_device_del: > >> > >> NOTE: This guarantees that associated sysfs callbacks are not running > >> or runnable, however any open cdevs will remain and their fops remain > >> callable even after this returns. > >> > >> Since I have seen a lot of confusion on that point as well.. > > > > Sure, I'll add that verbiage to a v3 sometime after rc1. > > It would also be great to patch1 into a stable non-rebasing git tree > so it can be used as a baseline for other 4.12 targeted development. > The device-dax patches in particular collide with some pending > development. I'll do that once -rc1 is out, I can't take any new patches right now :) thanks, greg k-h -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.