From: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
To: Nicolas Dichtel
<nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: arnd-r2nGTMty4D4@public.gmane.org,
mmarek-IBi9RG/b67k@public.gmane.org,
linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
slash.tmp-GANU6spQydw@public.gmane.org,
daniel.vetter-/w4YWyX8dFk@public.gmane.org,
rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jengelh-9+2X+4sQBs8@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 08/11] cryptouser.h: fix include from userland
Date: Wed, 1 Mar 2017 12:52:41 +0800 [thread overview]
Message-ID: <20170301045241.GB9156@gondor.apana.org.au> (raw)
In-Reply-To: <1488314857-28327-9-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
On Tue, Feb 28, 2017 at 09:47:34PM +0100, Nicolas Dichtel wrote:
> This patch prepares the uapi export by fixing the following error:
>
> .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function)
> char cru_name[CRYPTO_MAX_ALG_NAME];
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
> include/linux/crypto.h | 2 +-
> include/uapi/linux/cryptouser.h | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index c0b0cf3d2d2f..4cf29a35bb4b 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -24,6 +24,7 @@
> #include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/uaccess.h>
> +#include <uapi/linux/cryptouser.h>
Nack. cryptouser is just one interface in the crypto API. It
should not be included by every single crypto user in the kernel.
You could perhaps introduce a new file under uapi just for this.
Cheers,
--
Email: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-01 4:52 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170228024844.GA28691@altlinux.org>
2017-02-28 20:47 ` [PATCH v8 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 02/11] nios2: put setup.h " Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 08/11] cryptouser.h: " Nicolas Dichtel
[not found] ` <1488314857-28327-9-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2017-03-01 4:52 ` Herbert Xu [this message]
2017-03-02 16:56 ` [PATCH v9 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 02/11] nios2: put setup.h " Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 08/11] cryptouser.h: " Nicolas Dichtel
2017-03-03 9:35 ` Herbert Xu
[not found] ` <1488473802-13354-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2017-03-02 16:56 ` [PATCH v9 09/11] smc_diag.h: " Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 11/11] uapi: export all arch specifics directories Nicolas Dichtel
2017-03-03 17:07 ` [PATCH v9 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-10 16:34 ` Nicolas Dichtel
2017-03-11 5:43 ` Masahiro Yamada
2017-03-13 16:57 ` Nicolas Dichtel
2017-03-14 5:38 ` Masahiro Yamada
2017-03-14 8:25 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-27 5:31 ` Masahiro Yamada
2017-03-27 9:43 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 02/11] nios2: put setup.h " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-27 5:53 ` Masahiro Yamada
2017-03-27 9:45 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 08/11] cryptouser.h: " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 09/11] smc_diag.h: " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 11/11] uapi: export all arch specifics directories Nicolas Dichtel
2017-03-27 5:27 ` Masahiro Yamada
2017-03-27 9:42 ` Nicolas Dichtel
2017-03-24 8:32 ` [PATCH v10 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-24 8:42 ` Masahiro Yamada
2017-03-24 9:03 ` Nicolas Dichtel
2017-03-27 5:26 ` Masahiro Yamada
2017-03-27 9:45 ` Nicolas Dichtel
2017-03-27 15:33 ` Masahiro Yamada
2017-03-27 12:20 ` [PATCH v11 00/12] " Nicolas Dichtel
[not found] ` <1490617217-30192-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2017-03-27 12:20 ` [PATCH v11 01/12] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 02/12] nios2: put setup.h " Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 04/12] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 11/12] uapi: export all arch specifics directories Nicolas Dichtel
2017-05-16 1:02 ` Dan Williams
2017-05-16 1:15 ` Dan Williams
2017-05-16 4:59 ` Masahiro Yamada
2017-03-27 12:20 ` [PATCH v11 03/12] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 05/12] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 06/12] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 07/12] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 08/12] cryptouser.h: " Nicolas Dichtel
2017-04-11 2:40 ` Herbert Xu
2017-03-27 12:20 ` [PATCH v11 09/12] smc_diag.h: " Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 10/12] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 12/12] arch/include: remove empty Kbuild files Nicolas Dichtel
2017-03-27 15:35 ` [PATCH v11 00/12] uapi: export all headers under uapi directories Masahiro Yamada
2017-02-28 20:47 ` [PATCH v8 09/11] smc_diag.h: fix include from userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 11/11] uapi: export all arch specifics directories Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301045241.GB9156@gondor.apana.org.au \
--to=herbert-loam2ak0srrlbo1qdeomrrpzq4s04n8q@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=daniel.vetter-/w4YWyX8dFk@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jengelh-9+2X+4sQBs8@public.gmane.org \
--cc=ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mmarek-IBi9RG/b67k@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
--cc=rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=slash.tmp-GANU6spQydw@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox