[PATCH] IB/usnic: Remove unused functions

[PATCH] IB/usnic: Remove unused functions

[Yuval Shaia]

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/infiniband/hw/usnic/usnic_common_util.h | 29 -------------------------
 1 file changed, 29 deletions(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_common_util.h b/drivers/infiniband/hw/usnic/usnic_common_util.h
index b54986d..d757b82 100644
--- a/drivers/infiniband/hw/usnic/usnic_common_util.h
+++ b/drivers/infiniband/hw/usnic/usnic_common_util.h
@@ -35,22 +35,6 @@
 #define USNIC_CMN_UTIL_H
 
 static inline void
-usnic_mac_to_gid(const char *const mac, char *raw_gid)
-{
-	raw_gid[0] = 0xfe;
-	raw_gid[1] = 0x80;
-	memset(&raw_gid[2], 0, 6);
-	raw_gid[8] = mac[0]^2;
-	raw_gid[9] = mac[1];
-	raw_gid[10] = mac[2];
-	raw_gid[11] = 0xff;
-	raw_gid[12] = 0xfe;
-	raw_gid[13] = mac[3];
-	raw_gid[14] = mac[4];
-	raw_gid[15] = mac[5];
-}
-
-static inline void
 usnic_mac_ip_to_gid(const char *const mac, const __be32 inaddr, char *raw_gid)
 {
 	raw_gid[0] = 0xfe;
@@ -67,17 +51,4 @@
 	raw_gid[15] = mac[5];
 }
 
-static inline void
-usnic_write_gid_if_id_from_mac(char *mac, char *raw_gid)
-{
-	raw_gid[8] = mac[0]^2;
-	raw_gid[9] = mac[1];
-	raw_gid[10] = mac[2];
-	raw_gid[11] = 0xff;
-	raw_gid[12] = 0xfe;
-	raw_gid[13] = mac[3];
-	raw_gid[14] = mac[4];
-	raw_gid[15] = mac[5];
-}
-
 #endif /* USNIC_COMMON_UTIL_H */
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/usnic: Remove unused functions

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

On Wed, Mar 01, 2017 at 10:09:09PM +0200, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/infiniband/hw/usnic/usnic_common_util.h | 29 -------------------------
>  1 file changed, 29 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] IB/usnic: Remove unused functions

[Yuval Shaia]

On Thu, Mar 02, 2017 at 03:48:22PM +0200, Leon Romanovsky wrote:
> On Wed, Mar 01, 2017 at 10:09:09PM +0200, Yuval Shaia wrote:
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/infiniband/hw/usnic/usnic_common_util.h | 29 -------------------------
> >  1 file changed, 29 deletions(-)
> >
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Hi Doug,
If no more comments on this one can you consider taking it?

Thanks,
Yuval


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/usnic: Remove unused functions

[Yuval Shaia]

On Thu, Mar 02, 2017 at 03:48:22PM +0200, Leon Romanovsky wrote:
> On Wed, Mar 01, 2017 at 10:09:09PM +0200, Yuval Shaia wrote:
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/infiniband/hw/usnic/usnic_common_util.h | 29 -------------------------
> >  1 file changed, 29 deletions(-)
> >
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Hi Doug,
If no more comments on this one can you consider taking it?

Thanks,
Yuval


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/usnic: Remove unused functions

[Doug Ledford]

On Mon, 2017-04-24 at 18:49 +0300, Yuval Shaia wrote:
> On Thu, Mar 02, 2017 at 03:48:22PM +0200, Leon Romanovsky wrote:
> > 
> > On Wed, Mar 01, 2017 at 10:09:09PM +0200, Yuval Shaia wrote:
> > > 
> > > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  drivers/infiniband/hw/usnic/usnic_common_util.h | 29 ---------
> > > ----------------
> > >  1 file changed, 29 deletions(-)
> > > 
> > 
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Hi Doug,
> If no more comments on this one can you consider taking it?

I've pulled it in, thanks.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html