Re: [PATCH] iw_cxgb4: Use dsgl by default

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> Enable the use of dsgl by default and determine whether dsgl is
> supported from lld info.
>
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 410408f..8db7a11 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -38,9 +38,9 @@
>
>  #include "iw_cxgb4.h"
>
> -int use_dsgl = 0;
> +int use_dsgl = 1;
>  module_param(use_dsgl, int, 0644);
> -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");

Can we get rid of this module parameter completely?

>
>  #define T4_ULPTX_MIN_IO 32
>  #define C4IW_MAX_INLINE_SIZE 96
> @@ -231,7 +231,7 @@ static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len,
>  static int write_adapter_mem(struct c4iw_rdev *rdev, u32 addr, u32 len,
>  			     void *data, struct sk_buff *skb)
>  {
> -	if (is_t5(rdev->lldi.adapter_type) && use_dsgl) {
> +	if (rdev->lldi.ulptx_memwrite_dsgl && use_dsgl) {
>  		if (len > inline_threshold) {
>  			if (_c4iw_write_mem_dma(rdev, addr, len, data, skb)) {
>  				printk_ratelimited(KERN_WARNING
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]