[PATCH] iw_cxgb4: Use dsgl by default

[PATCH] iw_cxgb4: Use dsgl by default

[Ganesh Goudar]

Enable the use of dsgl by default and determine whether dsgl is
supported from lld info.

Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org> 
Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
 drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
index 410408f..8db7a11 100644
--- a/drivers/infiniband/hw/cxgb4/mem.c
+++ b/drivers/infiniband/hw/cxgb4/mem.c
@@ -38,9 +38,9 @@
 
 #include "iw_cxgb4.h"
 
-int use_dsgl = 0;
+int use_dsgl = 1;
 module_param(use_dsgl, int, 0644);
-MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
+MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
 
 #define T4_ULPTX_MIN_IO 32
 #define C4IW_MAX_INLINE_SIZE 96
@@ -231,7 +231,7 @@ static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len,
 static int write_adapter_mem(struct c4iw_rdev *rdev, u32 addr, u32 len,
 			     void *data, struct sk_buff *skb)
 {
-	if (is_t5(rdev->lldi.adapter_type) && use_dsgl) {
+	if (rdev->lldi.ulptx_memwrite_dsgl && use_dsgl) {
 		if (len > inline_threshold) {
 			if (_c4iw_write_mem_dma(rdev, addr, len, data, skb)) {
 				printk_ratelimited(KERN_WARNING
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iw_cxgb4: Use dsgl by default

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> Enable the use of dsgl by default and determine whether dsgl is
> supported from lld info.
>
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 410408f..8db7a11 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -38,9 +38,9 @@
>
>  #include "iw_cxgb4.h"
>
> -int use_dsgl = 0;
> +int use_dsgl = 1;
>  module_param(use_dsgl, int, 0644);
> -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");

Can we get rid of this module parameter completely?

>
>  #define T4_ULPTX_MIN_IO 32
>  #define C4IW_MAX_INLINE_SIZE 96
> @@ -231,7 +231,7 @@ static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len,
>  static int write_adapter_mem(struct c4iw_rdev *rdev, u32 addr, u32 len,
>  			     void *data, struct sk_buff *skb)
>  {
> -	if (is_t5(rdev->lldi.adapter_type) && use_dsgl) {
> +	if (rdev->lldi.ulptx_memwrite_dsgl && use_dsgl) {
>  		if (len > inline_threshold) {
>  			if (_c4iw_write_mem_dma(rdev, addr, len, data, skb)) {
>  				printk_ratelimited(KERN_WARNING
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [PATCH] iw_cxgb4: Use dsgl by default

[Steve Wise]

> 
> On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> > Enable the use of dsgl by default and determine whether dsgl is
> > supported from lld info.
> >
> > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/cxgb4/mem.c
> b/drivers/infiniband/hw/cxgb4/mem.c
> > index 410408f..8db7a11 100644
> > --- a/drivers/infiniband/hw/cxgb4/mem.c
> > +++ b/drivers/infiniband/hw/cxgb4/mem.c
> > @@ -38,9 +38,9 @@
> >
> >  #include "iw_cxgb4.h"
> >
> > -int use_dsgl = 0;
> > +int use_dsgl = 1;
> >  module_param(use_dsgl, int, 0644);
> > -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> > +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
> 
> Can we get rid of this module parameter completely?

We can, but we would need to deprecate it for a release or two.  I believe
removing them cold-turkey isn't recommended because it represents a form of user
interface...


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iw_cxgb4: Use dsgl by default

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

On Thu, Mar 02, 2017 at 09:02:17AM -0600, Steve Wise wrote:
> >
> > On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> > > Enable the use of dsgl by default and determine whether dsgl is
> > > supported from lld info.
> > >
> > > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > ---
> > >  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/cxgb4/mem.c
> > b/drivers/infiniband/hw/cxgb4/mem.c
> > > index 410408f..8db7a11 100644
> > > --- a/drivers/infiniband/hw/cxgb4/mem.c
> > > +++ b/drivers/infiniband/hw/cxgb4/mem.c
> > > @@ -38,9 +38,9 @@
> > >
> > >  #include "iw_cxgb4.h"
> > >
> > > -int use_dsgl = 0;
> > > +int use_dsgl = 1;
> > >  module_param(use_dsgl, int, 0644);
> > > -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> > > +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
> >
> > Can we get rid of this module parameter completely?
>
> We can, but we would need to deprecate it for a release or two.  I believe
> removing them cold-turkey isn't recommended because it represents a form of user
> interface...

You can rename it to be deprecated_use_dsgl instead of use_dsgl and wait
for a couple of years to see if someone complains.

Thanks

>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [PATCH] iw_cxgb4: Use dsgl by default

[Steve Wise]

> On Thu, Mar 02, 2017 at 09:02:17AM -0600, Steve Wise wrote:
> > >
> > > On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> > > > Enable the use of dsgl by default and determine whether dsgl is
> > > > supported from lld info.
> > > >
> > > > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > > Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > ---
> > > >  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/infiniband/hw/cxgb4/mem.c
> > > b/drivers/infiniband/hw/cxgb4/mem.c
> > > > index 410408f..8db7a11 100644
> > > > --- a/drivers/infiniband/hw/cxgb4/mem.c
> > > > +++ b/drivers/infiniband/hw/cxgb4/mem.c
> > > > @@ -38,9 +38,9 @@
> > > >
> > > >  #include "iw_cxgb4.h"
> > > >
> > > > -int use_dsgl = 0;
> > > > +int use_dsgl = 1;
> > > >  module_param(use_dsgl, int, 0644);
> > > > -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> > > > +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
> > >
> > > Can we get rid of this module parameter completely?
> >
> > We can, but we would need to deprecate it for a release or two.  I believe
> > removing them cold-turkey isn't recommended because it represents a form of
> user
> > interface...
> 
> You can rename it to be deprecated_use_dsgl instead of use_dsgl and wait
> for a couple of years to see if someone complains.
> 

I think for cxgb4 module options, we just add "DEPRECATED" to the description
for a few releases, then remove it.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iw_cxgb4: Use dsgl by default

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

On Thu, Mar 02, 2017 at 09:15:24AM -0600, Steve Wise wrote:
> > On Thu, Mar 02, 2017 at 09:02:17AM -0600, Steve Wise wrote:
> > > >
> > > > On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> > > > > Enable the use of dsgl by default and determine whether dsgl is
> > > > > supported from lld info.
> > > > >
> > > > > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > > > Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > > Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > > ---
> > > > >  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
> > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/infiniband/hw/cxgb4/mem.c
> > > > b/drivers/infiniband/hw/cxgb4/mem.c
> > > > > index 410408f..8db7a11 100644
> > > > > --- a/drivers/infiniband/hw/cxgb4/mem.c
> > > > > +++ b/drivers/infiniband/hw/cxgb4/mem.c
> > > > > @@ -38,9 +38,9 @@
> > > > >
> > > > >  #include "iw_cxgb4.h"
> > > > >
> > > > > -int use_dsgl = 0;
> > > > > +int use_dsgl = 1;
> > > > >  module_param(use_dsgl, int, 0644);
> > > > > -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> > > > > +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
> > > >
> > > > Can we get rid of this module parameter completely?
> > >
> > > We can, but we would need to deprecate it for a release or two.  I believe
> > > removing them cold-turkey isn't recommended because it represents a form of
> > user
> > > interface...
> >
> > You can rename it to be deprecated_use_dsgl instead of use_dsgl and wait
> > for a couple of years to see if someone complains.
> >
>
> I think for cxgb4 module options, we just add "DEPRECATED" to the description
> for a few releases, then remove it.

Sounds great.

>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] iw_cxgb4: Use dsgl by default

[Doug Ledford]

On Thu, 2017-02-23 at 12:31 +0530, Ganesh Goudar wrote:
> Enable the use of dsgl by default and determine whether dsgl is
> supported from lld info.
> 
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org> 
> Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>

I applied this, but I did add a deprecated tag to the module option
description.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iw_cxgb4: Use dsgl by default

[Steve Wise]

On 4/25/2017 1:05 PM, Doug Ledford wrote:
> On Thu, 2017-02-23 at 12:31 +0530, Ganesh Goudar wrote:
>> Enable the use of dsgl by default and determine whether dsgl is
>> supported from lld info.
>>
>> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>> Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> I applied this, but I did add a deprecated tag to the module option
> description.
>

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html