Re: [PATCH] IB/cq: Don't process more than the given budget

Bart Van Assche
2017-03-08T22:14:35Z

On Wed, 2017-03-08 at 23:12 +0100, hch-jcswGhMUV9g@public.gmane.org wrote:
> On Wed, Mar 08, 2017 at 10:09:08PM +0000, Bart Van Assche wrote:
> > > - while ((n = ib_poll_cq(cq, IB_POLL_BATCH, cq->wc)) > 0) {
> > > + while ((n = ib_poll_cq(cq, min(IB_POLL_BATCH, budget - completed),
> > > + cq->wc)) > 0) {
> > > for (i = 0; i < n; i++) {
> > > struct ib_wc *wc = &cq->wc[i];
> > >
> >
> > This breaks the SRP initiator driver since that driver can pass -1 as budget.
>
> Good point, we'd need to special case that.

How about using min_t(u32, IB_POLL_BATCH, budget - completed)?

Bart.--