From mboxrd@z Thu Jan 1 00:00:00 1970 From: "hch-jcswGhMUV9g@public.gmane.org" Subject: Re: [PATCH] IB/cq: Don't process more than the given budget Date: Wed, 8 Mar 2017 23:12:27 +0100 Message-ID: <20170308221227.GA447@lst.de> References: <1489003801-4410-1-git-send-email-sagi@grimberg.me> <1489010916.2813.4.camel@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1489010916.2813.4.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org" , "hch-jcswGhMUV9g@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Wed, Mar 08, 2017 at 10:09:08PM +0000, Bart Van Assche wrote: > > - while ((n = ib_poll_cq(cq, IB_POLL_BATCH, cq->wc)) > 0) { > > + while ((n = ib_poll_cq(cq, min(IB_POLL_BATCH, budget - completed), > > + cq->wc)) > 0) { > > for (i = 0; i < n; i++) { > > struct ib_wc *wc = &cq->wc[i]; > > > > This breaks the SRP initiator driver since that driver can pass -1 as budget. Good point, we'd need to special case that. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html