From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: libacm fails to build Date: Fri, 10 Mar 2017 11:43:59 -0700 Message-ID: <20170310184359.GA23455@obsidianresearch.com> References: <20170309171014.GC12694@obsidianresearch.com> <1489098918.2597.12.camel@sandisk.com> <20170309224904.GA5867@obsidianresearch.com> <1489099998.2597.16.camel@sandisk.com> <20170309230453.GA7844@obsidianresearch.com> <1489101151.2597.18.camel@sandisk.com> <20170309232352.GA12387@obsidianresearch.com> <1489103252.2597.20.camel@sandisk.com> <20170309235406.GA16385@obsidianresearch.com> <1489103888.2597.21.camel@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1489103888.2597.21.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: "pth-l3A5Bk7waGM@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, Mar 09, 2017 at 11:58:21PM +0000, Bart Van Assche wrote: > On Thu, 2017-03-09 at 16:54 -0700, Jason Gunthorpe wrote: > > Yes, I think so, like this? > > > > diff --git a/rdma-core.spec b/rdma-core.spec > > index 6519bc370a230a..df65745ff9c468 100644 > > +++ b/rdma-core.spec > > @@ -26,7 +26,9 @@ BuildRequires: valgrind-devel > > # SuSE releases have it, and sometime around cmake 3.3.2-1.2 the macros learned to use it. > > BuildRequires: ninja,make > > %define __builder ninja > > -# cmake_install,make_jobs is specified by opensuse > > +# cmake_install is specified by opensuse. It also specifies make_jobs, but it > > +# doesn't work with __builder as other rpm macro packages define it too. > > +%define make_jobs ninja-build -v %{?_smp_mflags} > > > > # Tumbleweed's cmake RPM macro adds -Wl,--no-undefined to the module flags > > # which is totally inappropriate and breaks building 'ENABLE_EXPORTS' style > > If ninja-build is changed into ninja or %{__builder} then I agree :-) done https://github.com/linux-rdma/rdma-core/pull/92 Thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html