From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject Date: Mon, 13 Mar 2017 11:23:27 +0200 Message-ID: <20170313092327.GK2079@mtr-leonro.local> References: <1489383828-7699-1-git-send-email-yanjun.zhu@oracle.com> <1489383828-7699-2-git-send-email-yanjun.zhu@oracle.com> <20170313063224.GJ2079@mtr-leonro.local> <58C63F06.6090804@oracle.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K1n7F7fSdjvFAEnM" Return-path: Content-Disposition: inline In-Reply-To: <58C63F06.6090804-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yanjun Zhu Cc: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org List-Id: linux-rdma@vger.kernel.org --K1n7F7fSdjvFAEnM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 13, 2017 at 02:41:10PM +0800, Yanjun Zhu wrote: > > > On 2017/3/13 14:32, Leon Romanovsky wrote: > > On Mon, Mar 13, 2017 at 01:43:45AM -0400, Zhu Yanjun wrote: > > > When rdma_accept fails, rdma_reject is called in it. As such, it is > > > not necessary to execute rdma_reject again. > > It is not always correct, according to the code, rdma_accept can fail > > and will return EINVAL and skip calling to rdma_reject. > Sure. When -EINVAL is returned, By this function cma_comp(id_priv, > RDMA_CM_CONNECT), the connection > is lost. As such, it does not matter whether sending rdma_reject or not. Thanks for the explanation.. > > Zhu Yanjun > > > > 3725 int rdma_accept(struct rdma_cm_id *id, struct rdma_conn_param *conn_param) > > 3726 { > > 3727 struct rdma_id_private *id_priv; > > 3728 int ret; > > 3729 > > 3730 id_priv = container_of(id, struct rdma_id_private, id); > > 3731 > > 3732 id_priv->owner = task_pid_nr(current); > > 3733 > > 3734 if (!cma_comp(id_priv, RDMA_CM_CONNECT)) > > 3735 return -EINVAL; > > 3736 > > > > > > > Cc: Joe Jin > > > Cc: Junxiao Bi > > > Acked-by: Santosh Shilimkar > > > Signed-off-by: Zhu Yanjun > > > --- > > > net/rds/ib_cm.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c > > > index ce3775a..4b9405c 100644 > > > --- a/net/rds/ib_cm.c > > > +++ b/net/rds/ib_cm.c > > > @@ -677,9 +677,8 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, > > > event->param.conn.initiator_depth); > > > > > > /* rdma_accept() calls rdma_reject() internally if it fails */ > > > - err = rdma_accept(cm_id, &conn_param); > > > - if (err) > > > - rds_ib_conn_error(conn, "rdma_accept failed (%d)\n", err); > > > + if (rdma_accept(cm_id, &conn_param)) > > > + rds_ib_conn_error(conn, "rdma_accept failed\n"); > > > > > > out: > > > if (conn) > > > -- > > > 2.7.4 > > > > --K1n7F7fSdjvFAEnM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAljGZQ8ACgkQ5GN7iDZy WKei+xAAj3X+Jv3hjhCpT6sZ7P22ou3WgOkVPkbHI7D5+XVhxue/UMJVs4lYM3XH yClbg4yJw16hD4JP6pCv91e7JP+QUDe+AQfo7vcdswsyufvKYTjVKjp0W69wQIug IJRkH6kRKut6Knd6plyISNkH4cWJXHp35dMGBIbftiKFQVqkStBN7vkQN6/fqRw6 0L5vBiS+onsDK6rbu6pn6QPoV4UgFi1vVBT7PfrzfsZpGbQIQz1BwItpaX3NCG64 ugD5oJ8vZ49aBaUljP9NoZsnPsq5fKJrbrwHfp8ZcEXubTBG7d5gJmmUdJ2PuMzb YuuRK/6to/bYTQrVlIk4vdjx99yoPVFvloaaOV3AfSxronoKneIzcZ69MtvOQsUR mj96fDna7r66pQi91Ztks+F2hgZVwDwPTC4CRzBCflHYK+kwLoG2ivtobwrfA19b /uis4umfnV65OEz4s57USxYraJMseh9D3t0su4+8SYlHrnfD7a3kuHmRJdwota0b 7FbeHBBFB1autgT+ZDC3uYd2xiqVeKaHCMaPf/E4GOW0e8ZpHXYi92CL0VyWDXIC MKrrKrPliVIItsd1cn2W5BtileKD2xVA8pKvgVsvMllQeaZMy7bYUWrQWG++5ZdV bsliRit4CZ25JAN/cBK7QpA2LBH/tMurLIUAipHna4Nh5kwgPfs= =2ZHE -----END PGP SIGNATURE----- --K1n7F7fSdjvFAEnM-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html