From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC v1 for accelerated IPoIB 05/25] IB/ipoib: Support ipoib acceleration options callbacks Date: Wed, 15 Mar 2017 10:46:52 -0600 Message-ID: <20170315164651.GA1931@obsidianresearch.com> References: <1489429896-10781-1-git-send-email-erezsh@mellanox.com> <1489429896-10781-6-git-send-email-erezsh@mellanox.com> <20170313201049.GB2738@obsidianresearch.com> <20170314160616.GE3244@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Erez Shitrit Cc: Erez Shitrit , Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Leon Romanovsky , Niranjana Vishwanathapura List-Id: linux-rdma@vger.kernel.org On Wed, Mar 15, 2017 at 06:27:23PM +0200, Erez Shitrit wrote: > > Move things like priv->napi into ipoib_rn_default, only the stuff > > under rdma_netdev should touch NAPI. > > When no accelerator is around, ipoib should work as before, and the > struct struct ipoib_dev_priv is the one who does all datapath and > control. The point is to make the code maintainable, by moving everything that is only used by *_default out of ipoib_dev_priv we can use the compiler to prove it isn't being used improperly by the core code. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html