From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH rdma-core 4/6] rdmacm: Use C11 stdatomic for all atomics
Date: Thu, 16 Mar 2017 10:16:26 -0600 [thread overview]
Message-ID: <20170316161626.GE23821@obsidianresearch.com> (raw)
In-Reply-To: <1489626275.3542.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Thu, Mar 16, 2017 at 01:04:49AM +0000, Bart Van Assche wrote:
> Have you considered to introduce something like the function below? I think
> that would make the changes smaller and hence easier to review.
I started like this and then just inlined the arithmatic in the few
call sites.
I think the algorithm reads as clearly either way and I generally
prefer to use the standard library directly..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-16 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 22:12 [PATCH rdma-core 0/6] Sparse code changes Jason Gunthorpe
[not found] ` <1489615927-12117-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-15 22:12 ` [PATCH rdma-core 1/6] Use NULL instead of 0 to silence sparse Jason Gunthorpe
2017-03-15 22:12 ` [PATCH rdma-core 2/6] INADDR_* needs to be byteswapped before being used Jason Gunthorpe
2017-03-15 22:12 ` [PATCH rdma-core 3/6] rstream: Use waitpid instead of wait Jason Gunthorpe
2017-03-15 22:12 ` [PATCH rdma-core 4/6] rdmacm: Use C11 stdatomic for all atomics Jason Gunthorpe
[not found] ` <1489615927-12117-5-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-15 22:55 ` Bart Van Assche
[not found] ` <1489618538.2660.14.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-15 23:18 ` Jason Gunthorpe
[not found] ` <20170315231837.GA23082-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-16 1:04 ` Bart Van Assche
[not found] ` <1489626275.3542.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-16 16:16 ` Jason Gunthorpe [this message]
2017-03-15 22:12 ` [PATCH rdma-core 5/6] rsocket: Fix byte swapping when constructing path records Jason Gunthorpe
2017-03-15 22:12 ` [PATCH rdma-core 6/6] verbs: Consistently apply __attribute_const Jason Gunthorpe
2017-03-21 17:24 ` [PATCH rdma-core 0/6] Sparse code changes Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316161626.GE23821@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox