* [PATCH rdma-core] fix udma_to_device_barrier on aarch64
@ 2017-03-23 2:12 Jarod Wilson
[not found] ` <20170323021224.35722-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Jarod Wilson @ 2017-03-23 2:12 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Jarod Wilson, Jason Gunthorpe
The definition for udma_to_device_barrier on aarch64 is missing. Looks
like an oversight in the commit that removed the old barrier macros and
added this one.
Fixes: 85a5529dead5 ("Remove the old barrier macros")
CC: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
util/udma_barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/udma_barrier.h b/util/udma_barrier.h
index 86578af5..9932a687 100644
--- a/util/udma_barrier.h
+++ b/util/udma_barrier.h
@@ -93,7 +93,7 @@
#elif defined(__sparc_v9__)
#define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
#elif defined(__aarch64__)
-#define wmb() asm volatile("dsb st" ::: "memory");
+#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
#elif defined(__sparc__) || defined(__s390x__)
#define udma_to_device_barrier() asm volatile("" ::: "memory")
#else
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-core] fix udma_to_device_barrier on aarch64
[not found] ` <20170323021224.35722-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2017-03-23 17:00 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2017-03-23 17:00 UTC (permalink / raw)
To: Jarod Wilson; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Wed, Mar 22, 2017 at 10:12:24PM -0400, Jarod Wilson wrote:
> The definition for udma_to_device_barrier on aarch64 is missing. Looks
> like an oversight in the commit that removed the old barrier macros and
> added this one.
>
> Fixes: 85a5529dead5 ("Remove the old barrier macros")
> CC: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> util/udma_barrier.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/udma_barrier.h b/util/udma_barrier.h
> index 86578af5..9932a687 100644
> +++ b/util/udma_barrier.h
> @@ -93,7 +93,7 @@
> #elif defined(__sparc_v9__)
> #define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
> #elif defined(__aarch64__)
> -#define wmb() asm volatile("dsb st" ::: "memory");
> +#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
> #elif defined(__sparc__) || defined(__s390x__)
> #define udma_to_device_barrier() asm volatile("" ::: "memory")
> #else
Doh, yep my bad.
https://github.com/linux-rdma/rdma-core/pull/106
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 2:12 [PATCH rdma-core] fix udma_to_device_barrier on aarch64 Jarod Wilson
[not found] ` <20170323021224.35722-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-23 17:00 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox