linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH rdma-core] rpm: BR: python for libmlx5
@ 2017-03-23  2:12 Jarod Wilson
       [not found] ` <20170323021246.35786-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Jarod Wilson @ 2017-03-23  2:12 UTC (permalink / raw)
  To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Jarod Wilson, Leon Romanovsky

The relpath python script added in commit 07764bc805ba requires python to
run, thus we must BuildRequires: python in the rpm spec files, or the
build will fail in minimal environments (such as mock).

Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
CC: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 rdma-core.spec        | 1 +
 redhat/rdma-core.spec | 1 +
 2 files changed, 2 insertions(+)

diff --git a/rdma-core.spec b/rdma-core.spec
index 3f6e73a0..6a280fe1 100644
--- a/rdma-core.spec
+++ b/rdma-core.spec
@@ -19,6 +19,7 @@ BuildRequires: pkgconfig
 BuildRequires: pkgconfig(libnl-3.0)
 BuildRequires: pkgconfig(libnl-route-3.0)
 BuildRequires: valgrind-devel
+BuildRequires: python
 
 # Since we recommend developers use Ninja, so should packagers, for consistency.
 %define CMAKE_FLAGS %{nil}
diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
index 5f6ead42..6b56eae4 100644
--- a/redhat/rdma-core.spec
+++ b/redhat/rdma-core.spec
@@ -20,6 +20,7 @@ BuildRequires: pkgconfig(libnl-3.0)
 BuildRequires: pkgconfig(libnl-route-3.0)
 BuildRequires: valgrind-devel
 BuildRequires: systemd
+BuildRequires: python
 
 Requires: dracut, kmod, systemd
 # Red Hat/Fedora previously shipped redhat/ as a stand-alone
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-core] rpm: BR: python for libmlx5
       [not found] ` <20170323021246.35786-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2017-03-23  3:47   ` Jason Gunthorpe
  2017-03-23 16:58   ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2017-03-23  3:47 UTC (permalink / raw)
  To: Jarod Wilson; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Leon Romanovsky

On Wed, Mar 22, 2017 at 10:12:46PM -0400, Jarod Wilson wrote:
> The relpath python script added in commit 07764bc805ba requires python to
> run, thus we must BuildRequires: python in the rpm spec files, or the
> build will fail in minimal environments (such as mock).
> 
> Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
> CC: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>  rdma-core.spec        | 1 +
>  redhat/rdma-core.spec | 1 +
>  2 files changed, 2 insertions(+)

I suspect we need to add python to debian/control as well, for the
same reasons.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-core] rpm: BR: python for libmlx5
       [not found] ` <20170323021246.35786-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  2017-03-23  3:47   ` Jason Gunthorpe
@ 2017-03-23 16:58   ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2017-03-23 16:58 UTC (permalink / raw)
  To: Jarod Wilson; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Leon Romanovsky

On Wed, Mar 22, 2017 at 10:12:46PM -0400, Jarod Wilson wrote:
> The relpath python script added in commit 07764bc805ba requires python to
> run, thus we must BuildRequires: python in the rpm spec files, or the
> build will fail in minimal environments (such as mock).
> 
> Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
> CC: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>  rdma-core.spec        | 1 +
>  redhat/rdma-core.spec | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/rdma-core.spec b/rdma-core.spec
> index 3f6e73a0..6a280fe1 100644
> +++ b/rdma-core.spec
> @@ -19,6 +19,7 @@ BuildRequires: pkgconfig
>  BuildRequires: pkgconfig(libnl-3.0)
>  BuildRequires: pkgconfig(libnl-route-3.0)
>  BuildRequires: valgrind-devel
> +BuildRequires: python
>  
>  # Since we recommend developers use Ninja, so should packagers, for consistency.
>  %define CMAKE_FLAGS %{nil}
> diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
> index 5f6ead42..6b56eae4 100644
> +++ b/redhat/rdma-core.spec
> @@ -20,6 +20,7 @@ BuildRequires: pkgconfig(libnl-3.0)
>  BuildRequires: pkgconfig(libnl-route-3.0)
>  BuildRequires: valgrind-devel
>  BuildRequires: systemd
> +BuildRequires: python
>  
>  Requires: dracut, kmod, systemd
>  # Red Hat/Fedora previously shipped redhat/ as a stand-alone

I added the debian bit and bundled it here:

https://github.com/linux-rdma/rdma-core/pull/106

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-23 16:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23  2:12 [PATCH rdma-core] rpm: BR: python for libmlx5 Jarod Wilson
     [not found] ` <20170323021246.35786-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-23  3:47   ` Jason Gunthorpe
2017-03-23 16:58   ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).