From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V2 rdma-core 6/6] Bump version and update debian
Date: Fri, 24 Mar 2017 12:09:14 -0600 [thread overview]
Message-ID: <20170324180914.GA13059@obsidianresearch.com> (raw)
In-Reply-To: <20170324134905.GE20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Fri, Mar 24, 2017 at 04:49:05PM +0300, Leon Romanovsky wrote:
> On Thu, Mar 23, 2017 at 02:02:14PM -0600, Jason Gunthorpe wrote:
> > On Thu, Mar 23, 2017 at 09:11:55PM +0200, Leon Romanovsky wrote:
> > > > > index 3defc05..f47fcec 100644
> > > > > +++ b/debian/changelog
> > > > > @@ -1,5 +1,8 @@
> > > > > -rdma-core (13-1) unstable; urgency=low
> > > > > +rdma-core (14-1) unstable; urgency=low
> > > > > +
> > > > > + * Bump version.
> > > >
> > > > I haven't been adding new change log entires in the past, this is just
> > > > a standin file - Debian will maintain their own in their .diff. Same
> > > > with rpm.
> > >
> > > It was more convenient for me to bump version in this file too,
> > > so new symbols in debian/*.symbol will have more clear minimal
> > > version (14-1), which is close to rdma-core-14.
> >
> > I meant, you still have to bump the version, I was just doing it in
> > place, because we are not actually keeping a changelog.
>
> And what about 13-1 in all *.symbols files? It will need to be changed
> too.
Do you need a changelog entry to have stuff in the symbols file?
BTW, there are bad looking things in travis with this PR:
parsechangelog/debian: warning: debian/changelog(l5): found start of entry where expected more change data or trailer
LINE: rdma-core (13-1) unstable; urgency=low
parsechangelog/debian: warning: debian/changelog(l5): found eof
where expected more change data or trailer
libmlx5.so.1 ibverbs-providers #MINVER#
MLX5_1.0@MLX5_1.0 13-1
MLX5_1.14@MLX5_1.14 14-1
+ MLX5_1.1@MLX5_1.1 14-1
+ mlx5dv_create_cq@MLX5_1.1 14-1
Etc..
https://travis-ci.org/linux-rdma/rdma-core/builds/214329236
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-24 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:55 [PATCH V2 rdma-core 0/6] Enable mlx5 vendor functionality Yishai Hadas
[not found] ` <1490277329-8738-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-03-23 13:55 ` [PATCH V2 rdma-core 1/6] mlx5: Explicitly align mlx5 query device response to 64 bit Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 2/6] mlx5: Report multi packet send WQE capability for mlx5 based hardware Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 3/6] mlx5: Report CQE compression capabilities through mlx5 direct verbs Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 4/6] verbs: Expose verbs init CQ helper API Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 5/6] mlx5: Expose direct create_cq with private data Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 6/6] Bump version and update debian Yishai Hadas
[not found] ` <1490277329-8738-7-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-03-23 17:19 ` Jason Gunthorpe
[not found] ` <20170323171916.GB5840-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-23 19:11 ` Leon Romanovsky
[not found] ` <20170323191155.GC20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-23 20:02 ` Jason Gunthorpe
[not found] ` <20170323200214.GA10344-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-24 13:49 ` Leon Romanovsky
[not found] ` <20170324134905.GE20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-24 18:09 ` Jason Gunthorpe [this message]
[not found] ` <20170324180914.GA13059-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-25 7:13 ` Leon Romanovsky
[not found] ` <20170325071326.GF20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-25 7:19 ` Leon Romanovsky
2017-03-26 20:45 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324180914.GA13059@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).