Re: [PATCH V2 rdma-core 6/6] Bump version and update debian

Jason Gunthorpe
2017-03-26T20:45:23Z

On Sat, Mar 25, 2017 at 10:13:26AM +0300, Leon Romanovsky wrote:
> > Do you need a changelog entry to have stuff in the symbols file?
>
> I think that we need corresponding version in changelog.

There are lots of counter examples..

libibverbs.so.1 libibverbs1 #MINVER#
IBVERBS_1.0@IBVERBS_1.0 1.1.6
IBVERBS_1.1@IBVERBS_1.1 1.1.6

Eg we do not have 1.1.6 in the changelog

> > BTW, there are bad looking things in travis with this PR:
> >
> > parsechangelog/debian: warning: debian/changelog(l5): found start of entry where expected more change data or trailer
> > LINE: rdma-core (13-1) unstable; urgency=low
> > parsechangelog/debian: warning: debian/changelog(l5): found eof
> > where expected more change data or trailer
> >
> > libmlx5.so.1 ibverbs-providers #MINVER#
> > MLX5_1.0@MLX5_1.0 13-1
> > MLX5_1.14@MLX5_1.14 14-1
> > + MLX5_1.1@MLX5_1.1 14-1
> > + mlx5dv_create_cq@MLX5_1.1 14-1
> >
> > Etc..
>
> It is actual error, strange that travis passed while it was supposed to fail.

Maybe we should run dpkg-shlibdeps manually and somehow fail if this
situation happens... Can you look at that?

> The commit
> https://github.com/linux-rdma/rdma-core/pull/103/commits/4ba27e66294f59db7c969bde1580e7aa8d718cd7
> added MLX5_1.1, but in commit
> https://github.com/linux-rdma/rdma-core/pull/103/commits/9614ecdae2a6a5448cab819a057c703a570b3686
> debian was updated with incorrect stanza (MLX5_1.14).

Yes, we went back and forth on this unfortunately, I gave some bad
advice.

Jason