public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: rdma-core.spec and -DIN_PLACE
Date: Mon, 27 Mar 2017 16:44:39 -0600	[thread overview]
Message-ID: <20170327224439.GA711@obsidianresearch.com> (raw)
In-Reply-To: <1490647788.7897.5.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

On Mon, Mar 27, 2017 at 08:50:01PM +0000, Bart Van Assche wrote:
> When I build an RPM using the top-level rdma-core.spec file I need the following
> patch to ensure that the verbs library looks into?/etc/libibverbs.d instead of a
> path in the build directory:

You certainly should not need something like this. I tried your script
in a tumbleweed container and it was fine...

Could something else in your envionrment be setting IN_PLACE?
Environment Variable? (Does rpmbuild not wipe those?) What does your
cmake line look like? Your script looks fine to me..

I added this to check, I didn't run anything..

diff --git a/CMakeLists.txt b/CMakeLists.txt
index da803443536925..33e0dad9868c70 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -51,6 +51,7 @@ set(PACKAGE_VERSION "13")
 
 # Override the CMAKE_INSTALL_ dirs to be under the build/ directory
 if (IN_PLACE)
+message(FATAL_ERROR "In place")
   set(CMAKE_INSTALL_SYSCONFDIR "${CMAKE_BINARY_DIR}/etc")
   set(CMAKE_INSTALL_BINDIR "${CMAKE_BINARY_DIR}/bin")
 endif()
diff --git a/rdma-core.spec b/rdma-core.spec
index 3f6e73a09ed12d..09c146f9324bd7 100644
--- a/rdma-core.spec
+++ b/rdma-core.spec
@@ -104,6 +104,7 @@ This is a simple example without the split sub packages to get things started.
 	 -DCMAKE_INSTALL_RUNDIR:PATH=%{_rundir} \
 	 -DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir}/%{name}-%{version} \
 	 -DCMAKE_INSTALL_UDEV_RULESDIR:PATH=%{_udevrulesdir}
+cat include/config.h
 %make_jobs
 
 %install
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-03-27 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 20:50 rdma-core.spec and -DIN_PLACE Bart Van Assche
     [not found] ` <1490647788.7897.5.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-27 22:44   ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327224439.GA711@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox