From: Yuval Shaia <yuval.shaia@oracle.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Mike Marciniszyn <infinipath@intel.com>,
Sean Hefty <sean.hefty@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs()
Date: Wed, 5 Apr 2017 18:17:48 +0300 [thread overview]
Message-ID: <20170405151747.GB5519@yuval-lap> (raw)
In-Reply-To: <20170405150658.GU3941@linux-x5ow.site>
On Wed, Apr 05, 2017 at 05:06:58PM +0200, Johannes Thumshirn wrote:
> On Wed, Apr 05, 2017 at 04:54:40PM +0200, SF Markus Elfring wrote:
> > >> @@ -7324,8 +7324,9 @@ struct qib_devdata *qib_init_iba7322_funcs(struct pci_dev *pdev,
> > >> actual_cnt -= dd->num_pports;
> > >>
> > >> tabsize = actual_cnt;
> > >> - dd->cspec->msix_entries = kzalloc(tabsize *
> > >> - sizeof(struct qib_msix_entry), GFP_KERNEL);
> > >> + dd->cspec->msix_entries = kcalloc(tabsize,
> > >> + sizeof(*dd->cspec->msix_entries),
> > >> + GFP_KERNEL);
> > >
> > > Are we fine with loosing the zeroing of the entries?
> >
> > How did you get this concern?
> >
> > Do you really miss such functionality from the other interface?
>
> Ahm... Don't kzalloc() and kcalloc() both pass in __GFP_ZERO?
Yes.
Please ignore my comment.
>
> --
> Johannes Thumshirn Storage
> jthumshirn@suse.de +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-04-05 15:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 13:50 [PATCH 0/5] IB/qib: Fine-tuning for four function implementations SF Markus Elfring
2017-04-05 13:51 ` [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() SF Markus Elfring
[not found] ` <5e5e00d3-b6a4-7371-65be-c5fe387d26b3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 14:34 ` Yuval Shaia
2017-04-05 14:54 ` SF Markus Elfring
2017-04-05 15:06 ` Johannes Thumshirn
2017-04-05 15:17 ` Yuval Shaia [this message]
2017-04-05 13:52 ` [PATCH 2/5] IB/qib: Use kmalloc_array() in qib_init_7322_variables() SF Markus Elfring
2017-04-05 14:21 ` Yuval Shaia
2017-04-05 13:53 ` [PATCH 3/5] IB/qib: Use kcalloc() in qib_alloc_devdata() SF Markus Elfring
2017-04-05 13:55 ` [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring
2017-04-05 14:32 ` Yuval Shaia
2017-04-05 15:04 ` SF Markus Elfring
2017-04-05 15:15 ` Yuval Shaia
2017-04-05 15:21 ` SF Markus Elfring
[not found] ` <c3885f83-8239-e21d-74fc-bf4fe03dd5dc-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-06 19:48 ` Yuval Shaia
2017-04-06 20:33 ` SF Markus Elfring
[not found] ` <b5bc4160-aace-b919-7fe2-a4742d03c4ba-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 15:10 ` [PATCH 5/5] " Bart Van Assche
[not found] ` <c16b18ac-287f-5faf-b79a-c86e2adfa22c-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-05 13:54 ` [PATCH 4/5] IB/qib: Use kcalloc() " SF Markus Elfring
2017-04-06 0:37 ` [PATCH 0/5] IB/qib: Fine-tuning for four function implementations Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405151747.GB5519@yuval-lap \
--to=yuval.shaia@oracle.com \
--cc=dledford@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox