From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] nvme-rdma: support devices with queue size < 32 Date: Mon, 10 Apr 2017 17:16:57 +0200 Message-ID: <20170410151657.GA15173@lst.de> References: <1519881025.363156294.1491837154312.JavaMail.zimbra@kalray.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1519881025.363156294.1491837154312.JavaMail.zimbra-FNhOzJFKnXGHXe+LvDLADg@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marta Rybczynska Cc: Leon Romanovsky , Doug Ledford , Jason Gunthorpe , Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, keith busch , axboe-b10kYP2dOMg@public.gmane.org, Max Gurtovoy , Samuel Jones List-Id: linux-rdma@vger.kernel.org > +static inline nvme_rdma_queue_sig_limit(struct nvme_rdma_queue *queue) > +{ > + int sig_limit; > + > + /* We signal completion every queue depth/2 and also > + * handle the case of possible device with queue_depth=1, > + * where we would need to signal every message. > + */ > + sig_limit = max(queue->queue_size / 2, 1); > + return (++queue->sig_count % sig_limit) == 0; > +} I would love if we could do this at the ib_qp level. I also know you found a real bug and we want it fixed ASAP, so maybe for now we should merge this one: Reviewed-by: Christoph Hellwig and then do the generic version. Marta, do you want to tackle the generic version or should I look into this once I get a little time. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html