From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH] IB/rxe: Don't clamp residual length to mtu Date: Thu, 13 Apr 2017 14:29:05 +0200 Message-ID: <20170413122905.GK6734@linux-x5ow.site> References: <20170406124944.11074-1-jthumshirn@suse.de> <20170413120000.GI6734@linux-x5ow.site> <20170413122200.GE1343@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170413122200.GE1343-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Moni Shoua , Sagi Grimberg , Max Gurtovoy , Linux Kernel Mailinglist , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hannes Reinecke List-Id: linux-rdma@vger.kernel.org On Thu, Apr 13, 2017 at 03:22:00PM +0300, Leon Romanovsky wrote: > On Thu, Apr 13, 2017 at 02:00:00PM +0200, Johannes Thumshirn wrote: > > On Thu, Apr 06, 2017 at 02:49:44PM +0200, Johannes Thumshirn wrote: > > > When reading a RDMA WRITE FIRST packet we copy the DMA length from the RDMA > > > header into the qp->resp.resid variable for later use. Later in check_rkey() > > > we clamp it to the MTU if the packet is an RDMA WRITE packet and has a > > > residual length bigger than the MTU. Later in write_data_in() we subtract the > > > payload of the packet from the residual length. If the packet happens to have a > > > payload of exactly the MTU size we end up with a residual length of 0 despite > > > the packet not being the last in the conversation. When the next packet in the > > > conversation arrives, we don't have any residual length left and thus set the QP > > > > Hi Moni, Sagi and Max, > > > > Any comments on this? > > Hi, > > I'm sorry, it looks like this patch failed on the floor. We have > Passover vacation these days and many people are OOO now. > > But anyway, I'll remind to Moni. Ok, thanks and happy Passover then. -- Johannes Thumshirn Storage jthumshirn-l3A5Bk7waGM@public.gmane.org +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html