[PATCH libibmad 2/2] gs.c: In performance_reset_via, use proper CounterSelect2 field for PortCountersExtended

[PATCH libibmad 2/2] gs.c: In performance_reset_via, use proper CounterSelect2 field for PortCountersExtended

[Hal Rosenstock]

Per MgtWG errata #9302

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/gs.c b/src/gs.c
index 5541b6b..90db7e2 100644
--- a/src/gs.c
+++ b/src/gs.c
@@ -110,11 +110,14 @@ uint8_t *performance_reset_via(void *rcvbuf, ib_portid_t * dest,
 
 	memset(rcvbuf, 0, IB_MAD_SIZE);
 
-	/* Same for attribute IDs */
+	/* Next 2 lines - same for attribute IDs */
 	mad_set_field(rcvbuf, 0, IB_PC_PORT_SELECT_F, port);
 	mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT_F, mask);
 	mask = mask >> 16;
-	mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT2_F, mask);
+	if (id == IB_GSI_PORT_COUNTERS_EXT)
+		mad_set_field(rcvbuf, 0, IB_PC_EXT_COUNTER_SELECT2_F, mask);
+	else
+		mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT2_F, mask);
 	rpc.attr.mod = 0;
 	rpc.timeout = timeout;
 	rpc.datasz = IB_PC_DATA_SZ;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH libibmad 2/2] gs.c: In performance_reset_via, use proper CounterSelect2 field for PortCountersExtended

[ira.weiny]

On Mon, Mar 27, 2017 at 11:35:44AM -0400, Hal Rosenstock wrote:
> 
> Per MgtWG errata #9302
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks applied,
Ira

> ---
> diff --git a/src/gs.c b/src/gs.c
> index 5541b6b..90db7e2 100644
> --- a/src/gs.c
> +++ b/src/gs.c
> @@ -110,11 +110,14 @@ uint8_t *performance_reset_via(void *rcvbuf, ib_portid_t * dest,
>  
>  	memset(rcvbuf, 0, IB_MAD_SIZE);
>  
> -	/* Same for attribute IDs */
> +	/* Next 2 lines - same for attribute IDs */
>  	mad_set_field(rcvbuf, 0, IB_PC_PORT_SELECT_F, port);
>  	mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT_F, mask);
>  	mask = mask >> 16;
> -	mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT2_F, mask);
> +	if (id == IB_GSI_PORT_COUNTERS_EXT)
> +		mad_set_field(rcvbuf, 0, IB_PC_EXT_COUNTER_SELECT2_F, mask);
> +	else
> +		mad_set_field(rcvbuf, 0, IB_PC_COUNTER_SELECT2_F, mask);
>  	rpc.attr.mod = 0;
>  	rpc.timeout = timeout;
>  	rpc.datasz = IB_PC_DATA_SZ;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html