[PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[Leon Romanovsky]

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Callers of rxe_mem_copy() provide pointer to store updated CRC
value. That pointer was supposed to be updated, but the
commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.

The code worked because there are no actual callers with
RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
The one caller in read_reply(), who uses the returned crcp didn't
set RXE_MEM_TYPE_DMA as mem->type.

Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
Reported-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Acked-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
Hi Doug,

It will be great if you forward this patch as part of your second pull request.
As you can see from the commit message, it fixes issue spotted by Andrew.

Thanks
---
 drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index ced15c4446bd..e37cc89987e1 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -368,7 +368,7 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length,
 			((void *)(uintptr_t)iova) : addr;

 		if (crcp)
-			crc = rxe_crc32(to_rdev(mem->pd->ibpd.device),
+			*crcp = rxe_crc32(to_rdev(mem->pd->ibpd.device),
 					*crcp, src, length);

 		memcpy(dest, src, length);
--
2.12.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[Boyer, Andrew]

On 5/4/17, 8:36 AM, "linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on behalf of Leon
Romanovsky" <linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on behalf of
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

>From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
>Callers of rxe_mem_copy() provide pointer to store updated CRC
>value. That pointer was supposed to be updated, but the
>commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
>mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.
>
>The code worked because there are no actual callers with
>RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
>The one caller in read_reply(), who uses the returned crcp didn't
>set RXE_MEM_TYPE_DMA as mem->type.
>
>Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
>Reported-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
>Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>Acked-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>---
>Hi Doug,
>
>It will be great if you forward this patch as part of your second pull
>request.
>As you can see from the commit message, it fixes issue spotted by Andrew.
>
>Thanks
>---
> drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

On Thu, May 04, 2017 at 01:21:15PM +0000, Boyer, Andrew wrote:
>
> On 5/4/17, 8:36 AM, "linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on behalf of Leon
> Romanovsky" <linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on behalf of
> leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> >From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> >Callers of rxe_mem_copy() provide pointer to store updated CRC
> >value. That pointer was supposed to be updated, but the
> >commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> >mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.
> >
> >The code worked because there are no actual callers with
> >RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
> >The one caller in read_reply(), who uses the returned crcp didn't
> >set RXE_MEM_TYPE_DMA as mem->type.
> >
> >Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> >Reported-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
> >Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >Acked-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >---
> >Hi Doug,
> >
> >It will be great if you forward this patch as part of your second pull
> >request.
> >As you can see from the commit message, it fixes issue spotted by Andrew.
> >
> >Thanks
> >---
> > drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>

Thank you for catching, reviewing and testing it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma] IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

[Doug Ledford]

On Thu, 2017-05-04 at 15:36 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Callers of rxe_mem_copy() provide pointer to store updated CRC
> value. That pointer was supposed to be updated, but the
> commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.
> 
> The code worked because there are no actual callers with
> RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
> The one caller in read_reply(), who uses the returned crcp didn't
> set RXE_MEM_TYPE_DMA as mem->type.
> 
> Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> Reported-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Acked-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> Hi Doug,
> 
> It will be great if you forward this patch as part of your second
> pull request.
> As you can see from the commit message, it fixes issue spotted by
> Andrew.

I've queued it for my second pull request, thanks.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html