[PATCH] NULL required to terminate attr array

[PATCH] NULL required to terminate attr array

[Steven Roberts]

This patch fixes a kernel panic when loading the hfi driver as a dynamic module.Addressing this patch will make performance tweaking the driver as a loadable mdule possible.

Signed-off-by: Steven Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sys
index 50d140d..2f3bbca 100644
--- a/drivers/infiniband/hw/hfi1/sysfs.c
+++ b/drivers/infiniband/hw/hfi1/sysfs.c
@@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct at
 };
 
 static struct attribute *port_cc_default_attributes[] = {
-       &cc_prescan_attr.attr
+       &cc_prescan_attr.attr,
+       NULL
 };
 
 static struct kobj_type port_cc_ktype = {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] NULL required to terminate attr array

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

On Tue, May 09, 2017 at 04:09:07PM -0500, Steven Roberts wrote:
>
> This patch fixes a kernel panic when loading the hfi driver as a dynamic module.Addressing this patch will make performance tweaking the driver as a loadable mdule possible.
>
> Signed-off-by: Steven Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sys
> index 50d140d..2f3bbca 100644
> --- a/drivers/infiniband/hw/hfi1/sysfs.c
> +++ b/drivers/infiniband/hw/hfi1/sysfs.c
> @@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct at
>  };
>
>  static struct attribute *port_cc_default_attributes[] = {
> -       &cc_prescan_attr.attr
> +       &cc_prescan_attr.attr,
> +       NULL
>  };
>
>  static struct kobj_type port_cc_ktype = {

How did you prepare the patch? Please use git format-patch, add
"IB/hfi1: " right after "[PATCH]" to limit the scope, add diffstat to
the patch and, run checkpathch.pl on it.

Thanks

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] IB/hfi1: NULL required to terminate attr array

[Steven Roberts]

This patch fixes a kernel panic when loading the hfi driver as a dynamic module.Addressing this patch will make performance tweaking the driver as a loadable module possible.

git diff | scripts/checkpatch.pl
total: 0 errors, 0 warnings, 9 lines checked

Your patch has no obvious style problems and is ready for submission.

Signed-off-by: Steven Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

 drivers/infiniband/hw/hfi1/sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sys
index 50d140d..2f3bbca 100644
--- a/drivers/infiniband/hw/hfi1/sysfs.c
+++ b/drivers/infiniband/hw/hfi1/sysfs.c
@@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct at
 };

 static struct attribute *port_cc_default_attributes[] = {
-       &cc_prescan_attr.attr
+       &cc_prescan_attr.attr,
+       NULL
 };

 static struct kobj_type port_cc_ktype = {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/hfi1: NULL required to terminate attr array

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Wed, May 10, 2017 at 08:40:30AM -0500, Steven Roberts wrote:
>
> This patch fixes a kernel panic when loading the hfi driver as a dynamic module.Addressing this patch will make performance tweaking the driver as a loadable module possible.
>
> git diff | scripts/checkpatch.pl
> total: 0 errors, 0 warnings, 9 lines checked
>
> Your patch has no obvious style problems and is ready for submission.
>
> Signed-off-by: Steven Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>  drivers/infiniband/hw/hfi1/sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Did you use git format-patch to create this patch? There is no --- after
your Singed-off-by and it says me that the answer will be no.

Please use git send-email to send patches and not as a reply, and please
limit your commit message to 80 symbols per-line.

You also should check the patch with checkpatch.pl and not the output of
git diff.

I recommend you to read SubmittingPatches doc.

Thanks

>
> diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sys
> index 50d140d..2f3bbca 100644
> --- a/drivers/infiniband/hw/hfi1/sysfs.c
> +++ b/drivers/infiniband/hw/hfi1/sysfs.c
> @@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct at
>  };
>
>  static struct attribute *port_cc_default_attributes[] = {
> -       &cc_prescan_attr.attr
> +       &cc_prescan_attr.attr,
> +       NULL
>  };
>
>  static struct kobj_type port_cc_ktype = {
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]