Re: [PATCH] IB/hfi1: NULL required to terminate attr array

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Wed, May 10, 2017 at 08:40:30AM -0500, Steven Roberts wrote:
>
> This patch fixes a kernel panic when loading the hfi driver as a dynamic module.Addressing this patch will make performance tweaking the driver as a loadable module possible.
>
> git diff | scripts/checkpatch.pl
> total: 0 errors, 0 warnings, 9 lines checked
>
> Your patch has no obvious style problems and is ready for submission.
>
> Signed-off-by: Steven Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>  drivers/infiniband/hw/hfi1/sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Did you use git format-patch to create this patch? There is no --- after
your Singed-off-by and it says me that the answer will be no.

Please use git send-email to send patches and not as a reply, and please
limit your commit message to 80 symbols per-line.

You also should check the patch with checkpatch.pl and not the output of
git diff.

I recommend you to read SubmittingPatches doc.

Thanks

>
> diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sys
> index 50d140d..2f3bbca 100644
> --- a/drivers/infiniband/hw/hfi1/sysfs.c
> +++ b/drivers/infiniband/hw/hfi1/sysfs.c
> @@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct at
>  };
>
>  static struct attribute *port_cc_default_attributes[] = {
> -       &cc_prescan_attr.attr
> +       &cc_prescan_attr.attr,
> +       NULL
>  };
>
>  static struct kobj_type port_cc_ktype = {
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]