linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	RDMA mailing list
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
	Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Noa Spanier <noas-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: rdma-core in Dabian
Date: Wed, 10 May 2017 09:50:05 -0600	[thread overview]
Message-ID: <20170510155005.GB1007@obsidianresearch.com> (raw)
In-Reply-To: <1494408947.3739.2.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>

On Wed, May 10, 2017 at 11:35:47AM +0200, Benjamin Drung wrote:
> Am Dienstag, den 09.05.2017, 12:05 -0600 schrieb Jason Gunthorpe:
> > On Tue, May 09, 2017 at 07:43:09PM +0200, Benjamin Drung wrote:
> > 
> > > * Can we upstream some redhat files, i.e. move them out of the
> > > redhat
> > > directory and maintain them in their corresponding code? Following
> > > files fall in this category:
> > 
> > Anything in the redhat directory could be moved out if it is going to
> > be used by another distro. It is there waiting for other distros to
> > look at it.
> 
> * The ifdown-ib and ifup-ib scripts are redhat-specific. It won't work
> with ifupdown from Debian.
> 
> * The files related to mlx4 look like a special handling for mlx4 to me
> and they do not following the KISS principle.

One part is managing the need to setup multi-protocol ports on
boot. This seems like a general requirement for mlx4/5 so maybe it
should get some more common solution..

> * What's the purpose of the cxgb{3,4} modprobe files?

cxgb is a multi-kernel module driver, those scripts are an attempt to
load the other parts when the main driver is loaded. I'm not sure why
cxgb is special enough to get these files but mlx/etc are not.

I suspect it is old cruft because redhat/rdma.kernel-init handles
things uniformly on systemd environments.

I've been thinking we should patch the kernel to solve this problem
instead of using this ugly userspace solution..

> Jarod already created a rdma-core package in debian/control in commit
> 8df5873b9. Currently we do not have a rdma-core package in Debian and
> no package with a kernel-boot service file. I know that the openibd and
>  mlnx-ofed-kernel-utils packages shipped a openibd service that does
> similar job.

Yes, pulling something like openibd into rdma-core is the idea here..

> Do we want to call the binary package that contains the kernel-boot
> service 'rdma-core' or simplify that to 'rdma'? We should use the same
> binary package name across the distributions (unless it's conflicting
> with a naming convention).

I think rdma-core is fine..

> Can you come up with a patch set? I will be happy to review it. Note
> that paths like /usr/libexec/rdma-init-kernel (in rdma.service) needs
> to be made configurable. In Debian, we would install these helper
> scripts in /usr/lib/$packagename/$filename.

Maybe Leon's team will try to tackle some of this? It is complicated,
the RH scripts do quite a bit stuff :\

But this doesn't seem particularly urgent for Debian packaging, right?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-05-10 15:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07  6:43 rdma-core in Dabian Leon Romanovsky
     [not found] ` <20170507064349.GM22833-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-09 17:43   ` Benjamin Drung
     [not found]     ` <1494351789.3752.5.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-09 17:54       ` Bart Van Assche
     [not found]         ` <1494352472.2518.10.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-09 18:18           ` Jason Gunthorpe
     [not found]             ` <20170509181807.GB9715-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-12 18:24               ` Bart Van Assche
     [not found]                 ` <1494613473.14477.12.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-12 19:51                   ` Jason Gunthorpe
2017-05-09 18:05       ` Jason Gunthorpe
     [not found]         ` <20170509180517.GA9715-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10  9:35           ` Benjamin Drung
     [not found]             ` <1494408947.3739.2.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-10 15:50               ` Jason Gunthorpe [this message]
     [not found]                 ` <20170510155005.GB1007-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10 16:02                   ` Leon Romanovsky
     [not found]                     ` <20170510160201.GD1839-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-10 16:24                       ` Benjamin Drung
2017-05-10 16:33                       ` Jason Gunthorpe
     [not found]                         ` <20170510163341.GA25041-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10 16:50                           ` Steve Wise
2017-05-10 16:58                             ` Jason Gunthorpe
2017-05-10 16:58                             ` Leon Romanovsky
     [not found]                               ` <20170510165858.GG1839-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-10 18:47                                 ` Steve Wise
2017-05-10 16:19                   ` Benjamin Drung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170510155005.GB1007@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=noas-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).