From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: 'Jason Gunthorpe'
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
'Benjamin Drung'
<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
'RDMA mailing list'
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Bart Van Assche'
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
'Talat Batheesh' <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
'Noa Spanier' <noas-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: rdma-core in Dabian
Date: Wed, 10 May 2017 19:58:58 +0300 [thread overview]
Message-ID: <20170510165858.GG1839@mtr-leonro.local> (raw)
In-Reply-To: <004001d2c9ad$7a141f70$6e3c5e50$@opengridcomputing.com>
[-- Attachment #1: Type: text/plain, Size: 2353 bytes --]
On Wed, May 10, 2017 at 11:50:06AM -0500, Steve Wise wrote:
> > From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org]
> >
> > On Wed, May 10, 2017 at 07:02:01PM +0300, Leon Romanovsky wrote:
> >
> > > > I've been thinking we should patch the kernel to solve this problem
> > > > instead of using this ugly userspace solution.
> > >
> > > Can it be related to the fact that mlx5 core calls to
> > > request_module_nowait for mlx5_ib and chelsio doesn't do it?
> >
> > Yeah, maybe we should update chelsio kernel drivers instead of using
> > these strange modprobe files...
> >
> > Steve?
>
> Under what criteria would cxgb4 want to request its Upper Layer Drivers (ULDs)
> to be loaded? You wouldn't want to load the iwarp and iscsi drivers if they
> aren't going to be used, would you?
If you don't want them, you will blacklist them. There is nothing wrong
with ready-to-use approach.
>
>
>
> >
> > > > Maybe Leon's team will try to tackle some of this? It is complicated,
> > > > the RH scripts do quite a bit stuff :\
> > >
> > > I would be happy to help, but I'm not sure that I understand what should
> > > be done :(
> >
> > I'm not totally clear either, TBH. The overall topic is to move files
> > out of redhat/ and into the common directory. This requires removing
> > the redhat-isms and making sure the redhat solution is what we really
> > want upstream.
> >
> > eg it seems rdma.cxgb[3]4.sys.modprobe is probably best done by patching
> > the kernel instead, not copying the modprobe files.
> >
> > rdma.kernel-init does:
> > - Load extra ULP modules
> > * /etc/rdma/rdma.conf is not appropriate for Debian
> > * 'TECH_PREVIEW' is a RedHat concept
> > - Obsolete mttr/errata stuff. This is in the kernel now (delete it)
> > - Yet another go at loading extra driver kernel modules (move to
> > kernel)
> > - Something about SRIOV (?)
> >
> > For ULP modules, I think we are loading too many by hand, again, the
> > kernel really needs fixing to autoload our stuff on first use. So, I
> > suggest a quick pass over that idea to see how much kernel code can be
> > fixed up.
> >
> > So the stuff to move to common user space code might just be the port
> > configuration and sriov? But someone needs to study this entire topic
> > with a broad view including the kernel.
> >
> > Jason
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-10 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 6:43 rdma-core in Dabian Leon Romanovsky
[not found] ` <20170507064349.GM22833-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-09 17:43 ` Benjamin Drung
[not found] ` <1494351789.3752.5.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-09 17:54 ` Bart Van Assche
[not found] ` <1494352472.2518.10.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-09 18:18 ` Jason Gunthorpe
[not found] ` <20170509181807.GB9715-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-12 18:24 ` Bart Van Assche
[not found] ` <1494613473.14477.12.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-12 19:51 ` Jason Gunthorpe
2017-05-09 18:05 ` Jason Gunthorpe
[not found] ` <20170509180517.GA9715-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10 9:35 ` Benjamin Drung
[not found] ` <1494408947.3739.2.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-10 15:50 ` Jason Gunthorpe
[not found] ` <20170510155005.GB1007-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10 16:02 ` Leon Romanovsky
[not found] ` <20170510160201.GD1839-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-10 16:24 ` Benjamin Drung
2017-05-10 16:33 ` Jason Gunthorpe
[not found] ` <20170510163341.GA25041-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-10 16:50 ` Steve Wise
2017-05-10 16:58 ` Jason Gunthorpe
2017-05-10 16:58 ` Leon Romanovsky [this message]
[not found] ` <20170510165858.GG1839-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-10 18:47 ` Steve Wise
2017-05-10 16:19 ` Benjamin Drung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510165858.GG1839@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=noas-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).