From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH rdma-rc] IB/IPoIB: Limit the ipoib_dev_uninit_default scope Date: Sun, 14 May 2017 21:26:15 +0300 Message-ID: <20170514182614.GB28994@yuval-lap> References: <20170514103206.6777-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170514103206.6777-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Sun, May 14, 2017 at 01:32:06PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > ipoib_dev_uninit_default() call is used in ipoib_main.c file only > and it generates the following warning from smatch tool: > drivers/infiniband/ulp/ipoib/ipoib_main.c:1593:6: warning: > symbol 'ipoib_dev_uninit_default' was not declared. Should it > be static? > > so let's declare that function as static. > > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 2869d1adb1de..a115c0b7a310 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -1590,7 +1590,7 @@ static void ipoib_neigh_hash_uninit(struct net_device *dev) > wait_for_completion(&priv->ntbl.deleted); > } > > -void ipoib_dev_uninit_default(struct net_device *dev) > +static void ipoib_dev_uninit_default(struct net_device *dev) > { > struct ipoib_dev_priv *priv = ipoib_priv(dev); > Reviewed-by: Yuval Shaia > -- > 2.12.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html