Re: [PATCH rdma-next] Revert "IB/core: Add flow control to the portmapper netlink calls"

Leon Romanovsky
2017-05-31T18:20:50Z

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On Wed, May 31, 2017 at 12:46:22PM -0500, Steve Wise wrote:
> >
> > > 4. Reverting is a common practice in Linux kernel. Patches are not
> > > carved in stones.
> >
> > Reverting a patch that's introduced during RC cycle is fine, introducing
> > regression is NOT and that is what you are doing by simply proposing to revert
> > this patch. Reverting this patch will introduce a REGRESSION error with
> respect to
> > port mapping functionality for all iWARP vendors.
> >
> > > 5. I proposed a solution -> go and fix your user space program.
> > This is a kernel patch you are trying to revert, you are breaking existing
> > kernel functionality. Nothing to do with user space.
> >
> > Bottom line, come up with a solution that will address both port mapper
> > functionality and your issue.
>
> Hey Leon,
>
> I would hate to introduce an iwarp regression vs solving your issue w/o
> reverting. If I recall, the flow control is need so as to not drop messages
> flowing from the kernel to the iwpmd. I'm not sure how that could be fixed in
> the user daemon?

Assume that netlink is unreliable and set socket timeout.

Thanks

>
> Steve.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]