Re: [PATCH rdma-next] Revert "IB/core: Add flow control to the portmapper netlink calls"

Shiraz Saleem
2017-05-30T21:24:31Z

On Mon, May 29, 2017 at 11:24:23AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-Nfu5REtnQAJWk0Htik3J/w@public.gmane.org>
>
> The commit cea05eadded0 ("IB/core: Add flow control to the portmapper netlink calls")
> changed netlink to be blocked for all RDMA clients. This workaround
> worked perfectly for portmapper, but is not correct for the whole
> NETLINK_RDMA family.
>
> The request/response should always be blocking and asynchronous
> notification should always be non-blocking.
>
> It is library and user-space application to chose how to handle recvmgs,
> as an example see nl_recvmsgs() and nl_socket_set_nonblocking() calls of
> libnl library.
>
> Send timeout is not needed too and can be configured with SO_SNDTIMEO socket
> option.
>
> This reverts commit cea05eadded0d4eb59f7be6e1f1560eb6bfde2bf.
>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

This commit was accepted with much feedback from you.

https://patchwork.kernel.org/patch/9235137/

Not clear from your description to determine what your trying to fix.

Simply reverting a commit that solves a real problem is not acceptable.

Please come up with a solution without breaking portmapper.

Shiraz