RE: [PATCH rdma-next] Revert "IB/core: Add flow control to the portmapper netlink calls"

Steve Wise
2017-05-31T17:46:22Z

>
> > 4. Reverting is a common practice in Linux kernel. Patches are not
> > carved in stones.
>
> Reverting a patch that's introduced during RC cycle is fine, introducing
> regression is NOT and that is what you are doing by simply proposing to revert
> this patch. Reverting this patch will introduce a REGRESSION error with
respect to
> port mapping functionality for all iWARP vendors.
>
> > 5. I proposed a solution -> go and fix your user space program.
> This is a kernel patch you are trying to revert, you are breaking existing
> kernel functionality. Nothing to do with user space.
>
> Bottom line, come up with a solution that will address both port mapper
> functionality and your issue.

Hey Leon,

I would hate to introduce an iwarp regression vs solving your issue w/o
reverting. If I recall, the flow control is need so as to not drop messages
flowing from the kernel to the iwpmd. I'm not sure how that could be fixed in
the user daemon?

Steve.