From: "Vishwanathapura, Niranjana" <niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
"Michael N. Henry"
<michael.n.henry-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] IB/core,rdmavt,hfi1,opa-vnic: Send OPA cap_mask3 in trap
Date: Sun, 4 Jun 2017 23:13:21 -0700 [thread overview]
Message-ID: <20170605061321.GA62566@knc-06.sc.intel.com> (raw)
In-Reply-To: <20170604164600.GE6868-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Sun, Jun 04, 2017 at 07:46:00PM +0300, Leon Romanovsky wrote:
>On Thu, Jun 01, 2017 at 05:04:02PM -0700, Vishwanathapura, Niranjana wrote:
>> --- a/drivers/infiniband/hw/hfi1/mad.c
>> +++ b/drivers/infiniband/hw/hfi1/mad.c
>> @@ -260,6 +260,7 @@ void hfi1_cap_mask_chg(struct rvt_dev_info *rdi, u8 port_num)
>> data.issuer_lid = cpu_to_be32(lid);
>> data.ntc_144.lid = data.issuer_lid;
>> data.ntc_144.new_cap_mask = cpu_to_be32(ibp->rvp.port_cap_flags);
>> + data.ntc_144.cap_mask3 = cpu_to_be16(ibp->rvp.port_cap3_flags);
>>
>> send_trap(ibp, &data, sizeof(data));
>> }
>> @@ -704,11 +705,7 @@ static int __subn_get_opa_portinfo(struct opa_smp *smp, u32 am, u8 *data,
>> buffer_units |= (dd->vl15_init << 11) & OPA_PI_MASK_BUF_UNIT_VL15_INIT;
>> pi->buffer_units = cpu_to_be32(buffer_units);
>>
>> - pi->opa_cap_mask = cpu_to_be16(OPA_CAP_MASK3_IsSharedSpaceSupported |
>> - OPA_CAP_MASK3_IsEthOnFabricSupported);
>> - /* Driver does not support mcast/collective configuration */
>> - pi->opa_cap_mask &=
>> - cpu_to_be16(~OPA_CAP_MASK3_IsAddrRangeConfigSupported);
>> + pi->opa_cap_mask = cpu_to_be16(ibp->rvp.port_cap3_flags);
>> pi->collectivemask_multicastmask = ((HFI1_COLLECTIVE_NR & 0x7)
>> << 3 | (HFI1_MCAST_NR & 0x7));
>>
>> diff --git a/drivers/infiniband/hw/hfi1/mad.h b/drivers/infiniband/hw/hfi1/mad.h
>> index 5aa3fd1..a4e2506 100644
>> --- a/drivers/infiniband/hw/hfi1/mad.h
>> +++ b/drivers/infiniband/hw/hfi1/mad.h
>> @@ -115,7 +115,7 @@ struct opa_mad_notice_attr {
>> __be32 lid; /* LID where change occurred */
>> __be32 new_cap_mask; /* new capability mask */
>> __be16 reserved2;
>> - __be16 cap_mask;
>> + __be16 cap_mask3;
>
>Did I miss the usage of that cap_mask3 field?
>
It is being set in mad.c above in this patch before sending the trap.
Niranjana
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-05 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 0:04 [PATCH v2] IB/core,rdmavt,hfi1,opa-vnic: Send OPA cap_mask3 in trap Vishwanathapura, Niranjana
[not found] ` <1496361842-58389-1-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-04 16:46 ` Leon Romanovsky
[not found] ` <20170604164600.GE6868-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-05 6:13 ` Vishwanathapura, Niranjana [this message]
[not found] ` <20170605061321.GA62566-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-06-05 6:17 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605061321.GA62566@knc-06.sc.intel.com \
--to=niranjana.vishwanathapura-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.n.henry-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox